From 2588e04ce15d8ce932900cb7b5d75e894082db46 Mon Sep 17 00:00:00 2001 From: Abhishek Koneru Date: Thu, 24 May 2012 16:11:53 -0400 Subject: Fixes for Coverity Issues CALL_SUPER,UNCONFIRMEDCAST,DEAD_STORE,TOSTRING_ARRAY --- base/java-tools/src/com/netscape/cmstools/AtoB.java | 2 +- base/java-tools/src/com/netscape/cmstools/CMCRevoke.java | 2 +- base/java-tools/src/com/netscape/cmstools/DRMTool.java | 2 +- base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java | 2 +- base/java-tools/src/com/netscape/cmstools/PrettyPrintCrl.java | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) (limited to 'base/java-tools/src') diff --git a/base/java-tools/src/com/netscape/cmstools/AtoB.java b/base/java-tools/src/com/netscape/cmstools/AtoB.java index 51fb3cc17..ee82da2e0 100644 --- a/base/java-tools/src/com/netscape/cmstools/AtoB.java +++ b/base/java-tools/src/com/netscape/cmstools/AtoB.java @@ -60,7 +60,7 @@ public class AtoB { public static void main(String argv[]) { BufferedReader inputBlob = null; - String asciiBASE64BlobChunk = ""; + String asciiBASE64BlobChunk; StringBuffer asciiBASE64Blob = new StringBuffer(); byte binaryBASE64Blob[] = null; diff --git a/base/java-tools/src/com/netscape/cmstools/CMCRevoke.java b/base/java-tools/src/com/netscape/cmstools/CMCRevoke.java index d76e93a52..aaf9fbb17 100644 --- a/base/java-tools/src/com/netscape/cmstools/CMCRevoke.java +++ b/base/java-tools/src/com/netscape/cmstools/CMCRevoke.java @@ -280,7 +280,7 @@ public class CMCRevoke { SignerIdentifier si = null; ContentInfo fullEnrollmentReq = null; String tokenname = "internal"; - String asciiBASE64Blob = ""; + String asciiBASE64Blob = null; try { diff --git a/base/java-tools/src/com/netscape/cmstools/DRMTool.java b/base/java-tools/src/com/netscape/cmstools/DRMTool.java index bb53f1bb3..efd83e892 100644 --- a/base/java-tools/src/com/netscape/cmstools/DRMTool.java +++ b/base/java-tools/src/com/netscape/cmstools/DRMTool.java @@ -1445,7 +1445,7 @@ public class DRMTool { */ private static PublicKey getPublicKey() { BufferedReader inputCert = null; - String encodedBASE64CertChunk = ""; + String encodedBASE64CertChunk; StringBuffer encodedBASE64Cert = new StringBuffer(); byte decodedBASE64Cert[] = null; X509CertImpl cert = null; diff --git a/base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java b/base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java index a713fb5a3..90d1eff9e 100644 --- a/base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java +++ b/base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java @@ -79,7 +79,7 @@ public class PrettyPrintCert { public static void main(String argv[]) { BufferedReader inputCert = null; - String encodedBASE64CertChunk = ""; + String encodedBASE64CertChunk; StringBuffer encodedBASE64Cert = new StringBuffer(); byte decodedBASE64Cert[] = null; diff --git a/base/java-tools/src/com/netscape/cmstools/PrettyPrintCrl.java b/base/java-tools/src/com/netscape/cmstools/PrettyPrintCrl.java index e9056dd48..ebee526d0 100644 --- a/base/java-tools/src/com/netscape/cmstools/PrettyPrintCrl.java +++ b/base/java-tools/src/com/netscape/cmstools/PrettyPrintCrl.java @@ -79,7 +79,7 @@ public class PrettyPrintCrl { X509CRLImpl crl = null; Locale aLocale = null; CrlPrettyPrint CrlDetails = null; - String pp = ""; + String pp; FileOutputStream outputCrl = null; // (1) Check that at least one argument was submitted to the program -- cgit