From e491cd5625968cf3d837e83f9f388014b446de97 Mon Sep 17 00:00:00 2001 From: Abhishek Koneru Date: Fri, 2 May 2014 19:16:03 -0400 Subject: Removed requestID parameter usage in [un]revoke request. There seems to be no use of the requestID parameter in both revoke and unrevoke request. Removed requestID attribute in CertRevokeRequest remove the class CertUnrevokeRequest. Also made changes in RevocationProcesor to use the requestID of the request created in it. The setRequestID() is being called in the DoRevoke and DoUnRevoke servlets. Removed the call and a function auditRequesterId in both the classes. The auditRequestorId method tries to get a "requestID" stored as a INPUT field in the reasonToRequest page. The ReasonToRevoke class which generates this page does not set the value. --- .../src/com/netscape/cmstools/cert/CertReleaseHoldCLI.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'base/java-tools/src/com/netscape/cmstools') diff --git a/base/java-tools/src/com/netscape/cmstools/cert/CertReleaseHoldCLI.java b/base/java-tools/src/com/netscape/cmstools/cert/CertReleaseHoldCLI.java index 42a8ae9ca..78beb12d0 100644 --- a/base/java-tools/src/com/netscape/cmstools/cert/CertReleaseHoldCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/cert/CertReleaseHoldCLI.java @@ -26,7 +26,6 @@ import org.apache.commons.cli.CommandLine; import com.netscape.certsrv.cert.CertData; import com.netscape.certsrv.cert.CertRequestInfo; -import com.netscape.certsrv.cert.CertUnrevokeRequest; import com.netscape.certsrv.dbs.certdb.CertId; import com.netscape.certsrv.request.RequestStatus; import com.netscape.cmstools.cli.CLI; @@ -101,9 +100,7 @@ public class CertReleaseHoldCLI extends CLI { } } - CertUnrevokeRequest request = new CertUnrevokeRequest(); - - CertRequestInfo certRequestInfo = certCLI.certClient.unrevokeCert(certID, request); + CertRequestInfo certRequestInfo = certCLI.certClient.unrevokeCert(certID); if (verbose) { CertCLI.printCertRequestInfo(certRequestInfo); -- cgit