From 9db76ed1d1f8969e93aaff320e49662f53688e2e Mon Sep 17 00:00:00 2001 From: Abhishek Koneru Date: Fri, 18 May 2012 16:12:17 -0400 Subject: Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION --- base/java-tools/src/com/netscape/cmstools/CMCResponse.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'base/java-tools/src/com/netscape/cmstools/CMCResponse.java') diff --git a/base/java-tools/src/com/netscape/cmstools/CMCResponse.java b/base/java-tools/src/com/netscape/cmstools/CMCResponse.java index 959f06f52..eae0b7303 100644 --- a/base/java-tools/src/com/netscape/cmstools/CMCResponse.java +++ b/base/java-tools/src/com/netscape/cmstools/CMCResponse.java @@ -73,7 +73,8 @@ public class CMCResponse { org.mozilla.jss.pkix.cms.SignedData cmcFullResp = (org.mozilla.jss.pkix.cms.SignedData) cii.getInterpretedContent(); - String content = ""; + StringBuffer content = new StringBuffer(); + if (cmcFullResp.hasCertificates()) { SET certs = cmcFullResp.getCertificates(); int numCerts = certs.size(); @@ -82,12 +83,12 @@ public class CMCResponse { Certificate cert = (Certificate) certs.elementAt(i); X509CertImpl certImpl = new X509CertImpl(ASN1Util.encode(cert)); CertPrettyPrint print = new CertPrettyPrint(certImpl); - content += print.toString(Locale.getDefault()); + content.append(print.toString(Locale.getDefault())); } } System.out.println("Certificates: "); - System.out.println(content); + System.out.println(content.toString()); System.out.println(""); EncapsulatedContentInfo ci = cmcFullResp.getContentInfo(); OBJECT_IDENTIFIER id = ci.getContentType(); -- cgit