From 10502e34a10fb3b672aef1161cc271003c7806ba Mon Sep 17 00:00:00 2001
From: Abhishek Koneru <akoneru@redhat.com>
Date: Wed, 27 Jun 2012 14:27:55 -0400
Subject: Fixes for Guarded_By_Violation issues shown in Coverity

---
 .../src/com/netscape/cmscore/dbs/CertificateRepository.java       | 8 +++++---
 base/common/src/com/netscape/cmscore/dbs/DBVirtualList.java       | 6 ++++--
 base/common/src/com/netscape/cmscore/dbs/KeyRepository.java       | 5 +++--
 3 files changed, 12 insertions(+), 7 deletions(-)

(limited to 'base/common/src/com/netscape/cmscore/dbs')

diff --git a/base/common/src/com/netscape/cmscore/dbs/CertificateRepository.java b/base/common/src/com/netscape/cmscore/dbs/CertificateRepository.java
index 0872d1f40..14e06aeb3 100644
--- a/base/common/src/com/netscape/cmscore/dbs/CertificateRepository.java
+++ b/base/common/src/com/netscape/cmscore/dbs/CertificateRepository.java
@@ -226,11 +226,13 @@ public class CertificateRepository extends Repository
      * 0 - disable
      * >0 - enable
      */
-    public void setCertStatusUpdateInterval(IRepository requestRepository, int interval, boolean listenToCloneModifications) {
+    public void setCertStatusUpdateInterval(IRepository requestRepository, int interval,
+            boolean listenToCloneModifications) {
 
         CMS.debug("In setCertStatusUpdateInterval " + interval);
-
-        this.requestRepository = requestRepository;
+        synchronized (this) {
+            this.requestRepository = requestRepository;
+        }
 
         // stop running tasks
         if (certStatusUpdateTask != null) {
diff --git a/base/common/src/com/netscape/cmscore/dbs/DBVirtualList.java b/base/common/src/com/netscape/cmscore/dbs/DBVirtualList.java
index 854a92e15..51a9230ac 100644
--- a/base/common/src/com/netscape/cmscore/dbs/DBVirtualList.java
+++ b/base/common/src/com/netscape/cmscore/dbs/DBVirtualList.java
@@ -308,9 +308,11 @@ public class DBVirtualList<E> implements IDBVirtualList<E> {
         if (sortKeys == null)
             throw new EBaseException("sort keys cannot be null");
         try {
-
             mKeys = new LDAPSortKey[sortKeys.length];
-            String la[] = mRegistry.getLDAPAttributes(sortKeys);
+            String la[] = null;
+            synchronized (this) {
+                la = mRegistry.getLDAPAttributes(sortKeys);
+            }
 
             for (int j = 0; j < sortKeys.length; j++) {
                 mKeys[j] = new LDAPSortKey(la[j]);
diff --git a/base/common/src/com/netscape/cmscore/dbs/KeyRepository.java b/base/common/src/com/netscape/cmscore/dbs/KeyRepository.java
index 0fbff688a..fb3b9b24a 100644
--- a/base/common/src/com/netscape/cmscore/dbs/KeyRepository.java
+++ b/base/common/src/com/netscape/cmscore/dbs/KeyRepository.java
@@ -154,8 +154,9 @@ public class KeyRepository extends Repository implements IKeyRepository {
     public void setKeyStatusUpdateInterval(IRepository requestRepo, int interval) {
 
         CMS.debug("In setKeyStatusUpdateInterval " + interval);
-
-        this.requestRepository = requestRepo;
+        synchronized (this) {
+            this.requestRepository = requestRepo;
+        }
 
         // stop running task
         if (mKeyStatusUpdateTask != null) {
-- 
cgit