From 3f24e55923fc986af4c6a08b2b8d45704a905627 Mon Sep 17 00:00:00 2001
From: Endi Sukma Dewata <edewata@redhat.com>
Date: Thu, 5 Apr 2012 15:08:18 -0500
Subject: Removed unnecessary type casts.

Unnecessary type casts have been removed using Eclipse Quick Fix.

Ticket #134
---
 .../com/netscape/cms/authorization/AAclAuthz.java  | 28 +++++++++++-----------
 .../netscape/cms/authorization/DirAclAuthz.java    |  4 ++--
 2 files changed, 16 insertions(+), 16 deletions(-)

(limited to 'base/common/src/com/netscape/cms/authorization')

diff --git a/base/common/src/com/netscape/cms/authorization/AAclAuthz.java b/base/common/src/com/netscape/cms/authorization/AAclAuthz.java
index 2e6636f27..b47956fb3 100644
--- a/base/common/src/com/netscape/cms/authorization/AAclAuthz.java
+++ b/base/common/src/com/netscape/cms/authorization/AAclAuthz.java
@@ -110,7 +110,7 @@ public abstract class AAclAuthz {
         Enumeration<String> mImpls = i.getSubStoreNames();
 
         while (mImpls.hasMoreElements()) {
-            String type = (String) mImpls.nextElement();
+            String type = mImpls.nextElement();
             String evalClassPath = null;
 
             try {
@@ -171,7 +171,7 @@ public abstract class AAclAuthz {
     }
 
     public IACL getACL(String target) {
-        return (ACL) mACLs.get(target);
+        return mACLs.get(target);
     }
 
     protected Enumeration<String> getTargetNames() {
@@ -310,7 +310,7 @@ public abstract class AAclAuthz {
      */
     private boolean checkACLs(String name, String perm)
             throws EACLsException {
-        ACL acl = (ACL) mACLs.get(name);
+        ACL acl = mACLs.get(name);
 
         // no such resource, pass it down
         if (acl == null) {
@@ -338,7 +338,7 @@ public abstract class AAclAuthz {
          * must pass all ACLEntry
          */
         for (; e.hasMoreElements();) {
-            ACLEntry entry = (ACLEntry) e.nextElement();
+            ACLEntry entry = e.nextElement();
 
             // if permission not pertinent, move on to next ACLEntry
             if (entry.containPermission(perm) == true) {
@@ -430,7 +430,7 @@ public abstract class AAclAuthz {
         int i = expression.indexOf("=");
         String type = expression.substring(0, i);
         String value = expression.substring(i + 1);
-        IAccessEvaluator evaluator = (IAccessEvaluator) mEvaluators.get(type);
+        IAccessEvaluator evaluator = mEvaluators.get(type);
 
         if (evaluator == null) {
             log(ILogger.LL_FAILURE, CMS.getLogMessage("AUTHZ_EVALUATOR_NOT_FOUND", type));
@@ -486,7 +486,7 @@ public abstract class AAclAuthz {
         boolean permitted = false;
 
         while (entries.hasMoreElements()) {
-            ACLEntry entry = (ACLEntry) entries.nextElement();
+            ACLEntry entry = entries.nextElement();
 
             CMS.debug("checkACLS(): ACLEntry expressions= " +
                     entry.getAttributeExpressions());
@@ -504,7 +504,7 @@ public abstract class AAclAuthz {
             entries = getDenyEntries(nodes, perm);
 
         while (entries.hasMoreElements()) {
-            ACLEntry entry = (ACLEntry) entries.nextElement();
+            ACLEntry entry = entries.nextElement();
 
             CMS.debug("checkACLS(): ACLEntry expressions= " +
                     entry.getAttributeExpressions());
@@ -541,13 +541,13 @@ public abstract class AAclAuthz {
         Vector<ACLEntry> v = new Vector<ACLEntry>();
 
         while (nodes.hasMoreElements()) {
-            name = (String) nodes.nextElement();
-            acl = (ACL) mACLs.get(name);
+            name = nodes.nextElement();
+            acl = mACLs.get(name);
             if (acl == null)
                 continue;
             e = acl.entries();
             while (e.hasMoreElements()) {
-                ACLEntry entry = (ACLEntry) e.nextElement();
+                ACLEntry entry = e.nextElement();
 
                 if (!entry.isNegative() &&
                         entry.containPermission(operation)) {
@@ -566,8 +566,8 @@ public abstract class AAclAuthz {
         Vector<ACLEntry> v = new Vector<ACLEntry>();
 
         while (nodes.hasMoreElements()) {
-            name = (String) nodes.nextElement();
-            acl = (ACL) mACLs.get(name);
+            name = nodes.nextElement();
+            acl = mACLs.get(name);
             if (acl == null)
                 continue;
             e = acl.entries();
@@ -690,7 +690,7 @@ public abstract class AAclAuthz {
             type = expression.substring(0, i).trim();
             value = expression.substring(i + len).trim();
         }
-        IAccessEvaluator evaluator = (IAccessEvaluator) mEvaluators.get(type);
+        IAccessEvaluator evaluator = mEvaluators.get(type);
 
         if (evaluator == null) {
             log(ILogger.LL_FAILURE, CMS.getLogMessage("AUTHZ_EVALUATOR_NOT_FOUND", type));
@@ -799,7 +799,7 @@ public abstract class AAclAuthz {
      * @return true if unique; false otherwise
      */
     public boolean isTypeUnique(String type) {
-        if (mACLs.containsKey((Object) type)) {
+        if (mACLs.containsKey(type)) {
             return false;
         } else {
             return true;
diff --git a/base/common/src/com/netscape/cms/authorization/DirAclAuthz.java b/base/common/src/com/netscape/cms/authorization/DirAclAuthz.java
index 040ff5297..bf4ca7f5a 100644
--- a/base/common/src/com/netscape/cms/authorization/DirAclAuthz.java
+++ b/base/common/src/com/netscape/cms/authorization/DirAclAuthz.java
@@ -164,7 +164,7 @@ public class DirAclAuthz extends AAclAuthz
                 LDAPAttribute aclRes = entry.getAttribute("resourceACLS");
 
                 @SuppressWarnings("unchecked")
-                Enumeration<String> en = (Enumeration<String>) aclRes.getStringValues();
+                Enumeration<String> en = aclRes.getStringValues();
 
                 for (; en != null && en.hasMoreElements();) {
                     addACLs(en.nextElement());
@@ -294,7 +294,7 @@ public class DirAclAuthz extends AAclAuthz
 
             if (en.hasMoreElements() == true) {
                 while (en.hasMoreElements()) {
-                    ACL a = (ACL) en.nextElement();
+                    ACL a = en.nextElement();
                     String resAclString = a.getResourceACLs();
 
                     attrs.addValue(resAclString);
-- 
cgit