From 3f24e55923fc986af4c6a08b2b8d45704a905627 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Thu, 5 Apr 2012 15:08:18 -0500 Subject: Removed unnecessary type casts. Unnecessary type casts have been removed using Eclipse Quick Fix. Ticket #134 --- base/common/src/com/netscape/cms/authentication/AVAPattern.java | 2 +- .../com/netscape/cms/authentication/AgentCertAuthentication.java | 2 +- base/common/src/com/netscape/cms/authentication/DNPattern.java | 2 +- base/common/src/com/netscape/cms/authentication/FlatFileAuth.java | 4 ++-- base/common/src/com/netscape/cms/authentication/PortalEnroll.java | 6 +++--- base/common/src/com/netscape/cms/authentication/RDNPattern.java | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) (limited to 'base/common/src/com/netscape/cms/authentication') diff --git a/base/common/src/com/netscape/cms/authentication/AVAPattern.java b/base/common/src/com/netscape/cms/authentication/AVAPattern.java index 55c62eeb1..823b396e9 100644 --- a/base/common/src/com/netscape/cms/authentication/AVAPattern.java +++ b/base/common/src/com/netscape/cms/authentication/AVAPattern.java @@ -457,7 +457,7 @@ class AVAPattern { Enumeration ldapValues = ldapAttr.getStringValues(); for (int i = 0; ldapValues.hasMoreElements(); i++) { - String val = (String) ldapValues.nextElement(); + String val = ldapValues.nextElement(); if (i == mElement) { value = val; diff --git a/base/common/src/com/netscape/cms/authentication/AgentCertAuthentication.java b/base/common/src/com/netscape/cms/authentication/AgentCertAuthentication.java index 03428102d..b8216d6bc 100644 --- a/base/common/src/com/netscape/cms/authentication/AgentCertAuthentication.java +++ b/base/common/src/com/netscape/cms/authentication/AgentCertAuthentication.java @@ -199,7 +199,7 @@ public class AgentCertAuthentication implements IAuthManager, Certificates certs = new Certificates(ci); try { - user = (IUser) mCULocator.locateUser(certs); + user = mCULocator.locateUser(certs); } catch (EUsrGrpException e) { throw new EInvalidCredentials(CMS.getUserMessage("CMS_AUTHENTICATION_INVALID_CREDENTIAL")); } catch (netscape.ldap.LDAPException e) { diff --git a/base/common/src/com/netscape/cms/authentication/DNPattern.java b/base/common/src/com/netscape/cms/authentication/DNPattern.java index e44f40e9d..ccee3b512 100644 --- a/base/common/src/com/netscape/cms/authentication/DNPattern.java +++ b/base/common/src/com/netscape/cms/authentication/DNPattern.java @@ -211,6 +211,6 @@ public class DNPattern { } public String[] getLdapAttrs() { - return (String[]) mLdapAttrs.clone(); + return mLdapAttrs.clone(); } } diff --git a/base/common/src/com/netscape/cms/authentication/FlatFileAuth.java b/base/common/src/com/netscape/cms/authentication/FlatFileAuth.java index 2394ede4c..81537f707 100644 --- a/base/common/src/com/netscape/cms/authentication/FlatFileAuth.java +++ b/base/common/src/com/netscape/cms/authentication/FlatFileAuth.java @@ -514,7 +514,7 @@ public class FlatFileAuth AuthToken authToken = new AuthToken(this); for (int i = 0; i < authAttrs.length; i++) { - String ffvalue = (String) user.get(authAttrs[i]); + String ffvalue = user.get(authAttrs[i]); String uservalue = (String) authCred.get(authAttrs[i]); // print("checking authentication token (" + authAttrs[i] + ": " + uservalue + " against ff value: " + ffvalue); @@ -589,7 +589,7 @@ public class FlatFileAuth // if a dn was specified in the password file for this user, // replace the requested dn with the one in the pwfile if (user != null) { - String dn = (String) user.get("dn"); + String dn = user.get("dn"); if (dn != null && authToken != null) { authToken.set(AuthToken.TOKEN_CERT_SUBJECT, dn); diff --git a/base/common/src/com/netscape/cms/authentication/PortalEnroll.java b/base/common/src/com/netscape/cms/authentication/PortalEnroll.java index 2e5b9d394..c94cec617 100644 --- a/base/common/src/com/netscape/cms/authentication/PortalEnroll.java +++ b/base/common/src/com/netscape/cms/authentication/PortalEnroll.java @@ -352,7 +352,7 @@ public class PortalEnroll extends DirBasedAuthentication { objectclass_values = mObjClasses; for (int i = objectclass_values.size() - 1; i >= 0; i--) - attr.addValue((String) objectclass_values.elementAt(i)); + attr.addValue(objectclass_values.elementAt(i)); attrs.add(attr); Enumeration> objClasses = mRequiredAttrs.elements(); @@ -369,7 +369,7 @@ public class PortalEnroll extends DirBasedAuthentication { if (attrname.equalsIgnoreCase("objectclass") == true) continue; try { - attrval = (String) argblk.getValueAsString(attrname); + attrval = argblk.getValueAsString(attrname); } catch (EBaseException e) { if (e.getMessage().equalsIgnoreCase(CMS.getUserMessage("CMS_BASE_ATTRIBUTE_NOT_FOUND")) == true) continue; @@ -393,7 +393,7 @@ public class PortalEnroll extends DirBasedAuthentication { CMS.debug("PortalEnroll: attrname is: " + attrname); try { - attrval = (String) argblk.getValueAsString(attrname); + attrval = argblk.getValueAsString(attrname); } catch (EBaseException e) { if (e.getMessage().equalsIgnoreCase(CMS.getUserMessage("CMS_BASE_ATTRIBUTE_NOT_FOUND")) == true) continue; diff --git a/base/common/src/com/netscape/cms/authentication/RDNPattern.java b/base/common/src/com/netscape/cms/authentication/RDNPattern.java index 35e3eb59a..14d5a2f8f 100644 --- a/base/common/src/com/netscape/cms/authentication/RDNPattern.java +++ b/base/common/src/com/netscape/cms/authentication/RDNPattern.java @@ -227,6 +227,6 @@ class RDNPattern { } public String[] getLdapAttrs() { - return (String[]) mLdapAttrs.clone(); + return mLdapAttrs.clone(); } } -- cgit