From 10326ad4fe1b3db620f43feb3f47c4fd008f3f33 Mon Sep 17 00:00:00 2001
From: Abhishek Koneru <akoneru@redhat.com>
Date: Mon, 11 Jun 2012 16:21:26 -0400
Subject: Fixes for Coverity issues of type Stringbuffer, NO_EQUALS_METHOD ,
 REVERSE_INULL,Wrong_Map_Iterators

---
 base/common/src/com/netscape/certsrv/common/NameValuePairs.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'base/common/src/com/netscape/certsrv/common/NameValuePairs.java')

diff --git a/base/common/src/com/netscape/certsrv/common/NameValuePairs.java b/base/common/src/com/netscape/certsrv/common/NameValuePairs.java
index 0f95ad2e3..30491cdd0 100644
--- a/base/common/src/com/netscape/certsrv/common/NameValuePairs.java
+++ b/base/common/src/com/netscape/certsrv/common/NameValuePairs.java
@@ -18,6 +18,7 @@
 package com.netscape.certsrv.common;
 
 import java.util.LinkedHashMap;
+import java.util.Map;
 import java.util.StringTokenizer;
 
 /**
@@ -43,12 +44,11 @@ public class NameValuePairs extends LinkedHashMap<String, String> {
      * @return string representation
      */
     public String toString() {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
 
-        for (String name : keySet()) {
-            String value = get(name);
+        for (Map.Entry<String, String> entry : entrySet()) {
 
-            buf.append(name + "=" + value);
+            buf.append(String.format("%s=%s", entry.getKey(), entry.getValue()));
             buf.append("\n");
         }
 
-- 
cgit