From 9db76ed1d1f8969e93aaff320e49662f53688e2e Mon Sep 17 00:00:00 2001
From: Abhishek Koneru <akoneru@redhat.com>
Date: Fri, 18 May 2012 16:12:17 -0400
Subject: Fixes for Coverity Defects of Category :
 FB.SBSC_USE_STRINGBUFFER_CONCATENATION

---
 base/common/src/com/netscape/certsrv/acls/ACL.java      |  8 ++++----
 base/common/src/com/netscape/certsrv/acls/ACLEntry.java | 14 +++++++-------
 2 files changed, 11 insertions(+), 11 deletions(-)

(limited to 'base/common/src/com/netscape/certsrv/acls')

diff --git a/base/common/src/com/netscape/certsrv/acls/ACL.java b/base/common/src/com/netscape/certsrv/acls/ACL.java
index 086b26015..83be047e7 100644
--- a/base/common/src/com/netscape/certsrv/acls/ACL.java
+++ b/base/common/src/com/netscape/certsrv/acls/ACL.java
@@ -151,17 +151,17 @@ public class ACL implements IACL, java.io.Serializable {
      *         <resource name>[<ACLEntry1>,<ACLEntry 2>,...<ACLEntry N>]
      */
     public String toString() {
-        String entries = "";
+        StringBuffer entries = new StringBuffer();
         Enumeration<ACLEntry> e = entries();
 
         for (; e.hasMoreElements();) {
             ACLEntry entry = e.nextElement();
 
-            entries += entry.toString();
+            entries.append(entry.toString());
             if (e.hasMoreElements())
-                entries += ",";
+                entries.append(",");
         }
-        return getName() + "[" + entries + "]";
+        return getName() + "[" + entries.toString() + "]";
     }
 
     /**
diff --git a/base/common/src/com/netscape/certsrv/acls/ACLEntry.java b/base/common/src/com/netscape/certsrv/acls/ACLEntry.java
index 3d18c263c..76924ed93 100644
--- a/base/common/src/com/netscape/certsrv/acls/ACLEntry.java
+++ b/base/common/src/com/netscape/certsrv/acls/ACLEntry.java
@@ -223,23 +223,23 @@ public class ACLEntry implements IACLEntry, java.io.Serializable {
      * @return string representation of this ACLEntry
      */
     public String toString() {
-        String entry = "";
+        StringBuffer entry = new StringBuffer();
 
         if (isNegative()) {
-            entry += "deny (";
+            entry.append("deny (");
         } else {
-            entry += "allow (";
+            entry.append("allow (");
         }
         Enumeration<String> e = permissions();
 
         for (; e.hasMoreElements();) {
             String p = e.nextElement();
 
-            entry += p;
+            entry.append(p);
             if (e.hasMoreElements())
-                entry += ",";
+                entry.append(",");
         }
-        entry += ") " + getAttributeExpressions();
-        return entry;
+        entry.append(") ").append(getAttributeExpressions());
+        return entry.toString();
     }
 }
-- 
cgit