From 9db76ed1d1f8969e93aaff320e49662f53688e2e Mon Sep 17 00:00:00 2001
From: Abhishek Koneru <akoneru@redhat.com>
Date: Fri, 18 May 2012 16:12:17 -0400
Subject: Fixes for Coverity Defects of Category :
 FB.SBSC_USE_STRINGBUFFER_CONCATENATION

---
 base/ca/src/com/netscape/ca/CRLIssuingPoint.java | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

(limited to 'base/ca')

diff --git a/base/ca/src/com/netscape/ca/CRLIssuingPoint.java b/base/ca/src/com/netscape/ca/CRLIssuingPoint.java
index aaeea2636..29bb1d1a1 100644
--- a/base/ca/src/com/netscape/ca/CRLIssuingPoint.java
+++ b/base/ca/src/com/netscape/ca/CRLIssuingPoint.java
@@ -1820,10 +1820,12 @@ public class CRLIssuingPoint implements ICRLIssuingPoint, Runnable {
             if (mProfileList.size() > 1) {
                 filter += "(|";
             }
+            StringBuffer tempBuffer = new StringBuffer();
             for (int k = 0; k < mProfileList.size(); k++) {
                 String id = mProfileList.elementAt(k);
-                filter += "(" + CertRecord.ATTR_META_INFO + "=profileId:" + id + ")";
+                tempBuffer.append("(" + CertRecord.ATTR_META_INFO + "=profileId:" + id + ")");
             }
+            filter += tempBuffer.toString();
             if (mProfileList.size() > 1) {
                 filter += ")";
             }
@@ -2481,14 +2483,15 @@ public class CRLIssuingPoint implements ICRLIssuingPoint, Runnable {
                     mDeltaCRLSize = deltaCRLCerts.size();
 
                     long totalTime = 0;
-                    String splitTimes = "  (";
+                    StringBuffer splitTimes = new StringBuffer();
+                    splitTimes.append("  (");
                     for (int i = 1; i < mSplits.length && i < 5; i++) {
                         totalTime += mSplits[i];
                         if (i > 1)
-                            splitTimes += ",";
-                        splitTimes += Long.toString(mSplits[i]);
+                            splitTimes.append(",");
+                        splitTimes.append(String.valueOf(mSplits[i]));
                     }
-                    splitTimes += ")";
+                    splitTimes.append(")");
                     mLogger.log(ILogger.EV_AUDIT, ILogger.S_OTHER,
                                 AuditFormat.LEVEL,
                                 CMS.getLogMessage("CMSCORE_CA_CA_DELTA_CRL_UPDATED"),
@@ -2499,7 +2502,7 @@ public class CRLIssuingPoint implements ICRLIssuingPoint, Runnable {
                                         getLastUpdate(),
                                         getNextDeltaUpdate(),
                                         Long.toString(mDeltaCRLSize),
-                                        Long.toString(totalTime) + splitTimes
+                                        Long.toString(totalTime) + splitTimes.toString()
                                 }
                                );
                 } catch (EBaseException e) {
-- 
cgit