summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Remove unnecessary global variables used only byjdennis2010-11-191-14/+3
| | | | | | | get_time_stamp() git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1540 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Add run_command() utilityjdennis2010-11-191-0/+81
| | | | | | | | | | | | | | | | | | | | | Many of the existing functions were using the backtic operator to run a shell command and then tested if the length returned string was zero to determine success. This is incorrect for two reasons: 1) the backtick operator discards stderr and returns only stdout, thus if the command did generate a message because of an error it would likely do so on stderr not stdout and thus the test for output is performed on the wrong stream. 2) the presence or absense of output is not the proper way to determine if a shell command succeeded, one needs to test the exit status of the command. This patch adds the run_command() function which will be utilized in subsequent patches. git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1539 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Reimplement copy_directory, remove_directoryjdennis2010-11-191-45/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The copy_directory function was losing critical information. It called out to the shell to recursively copy the contents of one directory to another. But this meant we lost track of the files and directories actually being copied, we couldn't log them nor add them to the installation manifest. Now the copy_directory function builds a list of files in the src directory and iteratively copies each file calling into our copy_file function which records the operation and checks for errors. The remove_directory function was an unapologetic sledge hammer, it simply nuked entire trees. Now the function is more sensible, by default it removed one empty directory, or optionally recursively removes all directory contents. Both functions previously had serious implementation mistakes. Both were implemented by calling out to a UNIX shell and invoking a shell command via the Perl backtick operator. The fundamental problems with this were: * UNIX shell commands only work on UNIX * Not all UNIX shell commands are identical * The error detection stragegy was completly broken. It executed the shell command via the backtick operator which returns the stdout of the command and discards stderr. The function would then test to see if the length of stdout was zero to determine if there was an error. If there was no stdout it assumed no errors occurred. This is completely wrong. To test if an error occurs with a shell command one needs to examine the exit status of the command which is impossible to do with the Perl backtick operator. If one wants to test the exit status of a shell command in Perl you must utilize the subprocess features of Perl. The reimplementation eschews the non-portable use of UNIX shell commands in favor of the portable Perl extensions for operating on filesystem directories. git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1538 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Obey style guidlines and existing practicejdennis2010-11-193-1762/+1761
| | | | | | | | | | - Single space after keyword. - No space after open parens. - No space before closing parens. - No unquoted bare words git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1537 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Introduce dry_run command line arg and global variablejdennis2010-11-193-9/+47
| | | | | | | | | | | | Dry run mode is used to show what the script would have done without performing any actions. Add logfile to pkiremove. Update copyright dates. git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1536 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Utilities to record installation activityjdennis2010-11-191-0/+395
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds utilites to track installation activity and produce an "Installation Manifest". Every filesystem path name which is modified during installation is recorded along with metadata about the installation action and what should be performed during an uninstall. The metadata is extensible. The table can be formatted in a variety of ways, either as a file which can be parsed (e.g. Installation Manifest), or as human readable friendly summary information. The installation file can be read later to perform an uninstall action. Previously a less complete cleanup.dat file was produced which omitted any information about files installed as part of a directory, distinction beween symbolic links and files/directories, and what should occur during an uninstall (e.g removal vs. preservation). The utilities can detect the old file format utilize them it to preserve backward compatibility. Because the new format is extensible any future needs should be easily accommodated. Aside from a more complete and accurate manifest and user report there is an additional benefit to this tracking information in terms of developer debugging. I found this more detailed reporting invaluable after modifying the installation script because it allowed me to see if what I expected to happen was happening or if things which weren't supposed to happen occurred. Formerly this was difficult information to extract and has enhanced robustness, both during development and during user install/uninstall. This patch only adds the utilities, it does not invoke them. git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1535 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Utilities to walk directoryjdennis2010-11-191-0/+272
| | | | | | | | | - add utilities to walk a directory structure and get a list of files in a tree. - also adds utility to normalize a directory path git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1534 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Handle the verbose flag betterjdennis2010-11-192-5/+12
| | | | | | | | | | | - Allow it to be specified multiple times to increment the verbosity level. - Add verbose option to pkiremove. Don't indent optional arg doc, leave room for more doc text. - update usage doc git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1533 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Use here doc syntax for readabilityjdennis2010-11-192-298/+275
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1532 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Adjust current files so patches merge, will adjust after merge completejdennis2010-11-196-140/+16
| | | | | | | | | pkicreate: index.jsp -> index.html server.xml: remove ocsp base/tps/doc/CS.cfg: CIMC_CERT_VERIFICATION git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1531 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Fix Bugzilla Bug 649910 - Console: an auditor or agent can be added to an ↵jmagne2010-11-195-3/+23
| | | | | | administrator group. Minor config addition. git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1528 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Fix Bugzilla Bug 649910 - Console: an auditor or agent can be added to an ↵jmagne2010-11-195-18/+51
| | | | | | administrator group. git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1526 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 606946 - Convert Native Tools to use ldapAPI from OpenLDAP ↵vakwetu2010-11-181-3/+6
| | | | | | instead of the Mozldap git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1524 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 606946 - Convert Native Tools to use ldapAPI from OpenLDAP ↵vakwetu2010-11-1813-6911/+3312
| | | | | | instead of the Mozldap git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1523 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 606946 - Convert Native Tools to use ldapAPI from OpenLDAP ↵vakwetu2010-11-171-847/+802
| | | | | | instead of the Mozldap - formatting changes git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1522 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Back out of unintended checkin.jmagne2010-11-171-1/+1
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1521 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Fix Bug 623452 - rhcs80 pkiconsole profile policy editor limit policy ↵jmagne2010-11-1720-162/+578
| | | | | | extension to 5 only git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1520 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 651916 - kra and ocsp are using incorrect ports to talk to CA ↵vakwetu2010-11-175-23/+34
| | | | | | and complete configuration in DonePanel: correction patch git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1517 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 499494 - change CA defaults to SHA2 (phase 1)cfu2010-11-173-4/+4
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1516 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug #489385 - references to rhpkimharmsen2010-11-162-1/+10
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1512 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 489385 - references to rhpkicfu2010-11-165-6/+6
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1511 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 651977 - turn off ssl2 for java servers (server.xml)cfu2010-11-164-13/+13
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1509 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 583754 - pki-silent needs an option to configure signing ↵vakwetu2010-11-164-24/+91
| | | | | | algorithm for CA certificates git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1507 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 653713 - CC: setting trust on a CIMC cert requires auditingcfu2010-11-161-1/+28
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1505 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 642359 - CC Feature - need to verify certificate when it is addedcfu2010-11-163-21/+52
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1503 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 511990 - rhcs 7.3, 8.0 - re-activate missing object signing support in RHCScfu2010-11-151-2/+2
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1501 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 651916 - kra and ocsp are using incorrect ports to talk to CA ↵vakwetu2010-11-151-0/+16
| | | | | | and complete configuration in DonePanel git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1499 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 651916 - kra and ocsp are using incorrect ports to talk to CA ↵vakwetu2010-11-1523-72/+206
| | | | | | and complete configuration in DonePanel git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1498 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 509481 - RFE: support sMIMECapabilities extensions in certificates (RFC ↵cfu2010-11-122-1/+110
| | | | | | 4262) git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1495 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Fix Bugzilla Bug 360721 - New Feature: Profile Integrity Check.jmagne2010-11-101-2/+10
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1493 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Fix Bugzilla Bug 360721 - New Feature: Profile Integrity Check . . .jmagne2010-11-103-6/+101
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1491 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 542863 - RHCS8: Default cert audit nickname written to CS.cfg files ↵cfu2010-11-092-0/+28
| | | | | | imcomplete when the cert is stored on a hsm git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1488 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* BZ651087: TPS UI Admin tab display 'null' string in the General configurationvakwetu2010-11-091-1/+2
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1485 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* BZ651040: cloning shoud not include sslservervakwetu2010-11-091-1/+1
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1484 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* BZ488253, BZ551410, BZ550331 - oscp asn1 encoding fixes, including code ↵vakwetu2010-11-093-440/+512
| | | | | | provided by David Studzman git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1482 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug #609641 - CC: need procedure (and possibly tools) to helpmharmsen2010-11-064-0/+39
| | | | | | | correctly set up CC environment git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1478 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 529945 - (Instructions and sample only) CS 8,0 GA release -- DRM and TKS ↵cfu2010-11-054-4/+128
| | | | | | do not seem to have CRL checking enabled git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1477 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 451874 - RFE - Java console - Certificate Wizard missing e.c. ↵vakwetu2010-11-041-8/+33
| | | | | | support git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1475 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 451874 - RFE - Java console - Certificate Wizard missing e.c. ↵vakwetu2010-11-041-7/+30
| | | | | | support git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1474 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 451874 - RFE - Java console - Certificate Wizard missing e.c. ↵vakwetu2010-11-0423-61/+587
| | | | | | support git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1473 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 638242 - Installation Wizard: at SizePanel, fix selection of ↵vakwetu2010-11-041-25/+316
| | | | | | signature algorithm; and for ECC curves git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1472 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug 638242 - Installation Wizard: at SizePanel, fix selection of ↵vakwetu2010-11-047-98/+217
| | | | | | signature algorithm; and for ECC curves git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1471 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 648757 - expose and use updated cert verification function in JSScfu2010-11-044-42/+92
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1470 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 645874 - rfe ecc - add ecc curve name support in JSS and CS interfacecfu2010-11-031-0/+59
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1467 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla BZ# 631179 - Administrator is not allowed to remove ocsp signing ↵vakwetu2010-11-023-3/+3
| | | | | | certificate using console git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1465 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Fix Bugzilla Bug 532724 - Feature: ESC Security officer work station should ↵jmagne2010-11-021-1/+1
| | | | | | display % of operation complete for format SO card git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1464 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bug 647364 - CC: audit signing certs for JAVA subsystems fail CIMC cert ↵cfu2010-11-021-22/+55
| | | | | | | | | verification (expose updated cert verification function in JSS) - matching Java side to allow non-specification of certusage git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1463 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Fix Bugzilla Bug 532724 - Feature: ESC Security officer work station should ↵jmagne2010-11-0213-16/+316
| | | | | | display % of operation complete for format SO card git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1461 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Fix Bugzilla Bug 532724 - Feature: ESC Security officer work station should ↵jmagne2010-11-026-0/+6
| | | | | | display % of operation complete for format SO card git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1460 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
* Bugzilla Bug #528249 - rhcs80 - web pages, css -moz-opacity deprecatedmharmsen2010-11-013-18/+12
| | | | git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1457 c9f7a03b-bd48-0410-a16d-cbbf54688b0b