diff options
Diffstat (limited to 'base/common/src/com/netscape/cms/servlet/cert/DoRevokeTPS.java')
| -rw-r--r-- | base/common/src/com/netscape/cms/servlet/cert/DoRevokeTPS.java | 45 |
1 files changed, 18 insertions, 27 deletions
diff --git a/base/common/src/com/netscape/cms/servlet/cert/DoRevokeTPS.java b/base/common/src/com/netscape/cms/servlet/cert/DoRevokeTPS.java index 35bdd5c8c..65abd8a22 100644 --- a/base/common/src/com/netscape/cms/servlet/cert/DoRevokeTPS.java +++ b/base/common/src/com/netscape/cms/servlet/cert/DoRevokeTPS.java @@ -325,7 +325,7 @@ public class DoRevokeTPS extends CMSServlet { String auditRequesterID = auditRequesterID(req); String auditSerialNumber = auditSerialNumber(null); String auditRequestType = auditRequestType(reason); - String auditApprovalStatus = ILogger.SIGNED_AUDIT_EMPTY_VALUE; + RequestStatus auditApprovalStatus = null; String auditReasonNum = String.valueOf(reason); if (revokeAll != null) { @@ -499,7 +499,7 @@ public class DoRevokeTPS extends CMSServlet { mQueue.processRequest(revReq); // retrieve the request status - auditApprovalStatus = revReq.getRequestStatus().toString(); + auditApprovalStatus = revReq.getRequestStatus(); RequestStatus stat = revReq.getRequestStatus(); String type = revReq.getRequestType(); @@ -550,12 +550,9 @@ public class DoRevokeTPS extends CMSServlet { // store a message in the signed audit log file // if and only if "auditApprovalStatus" is // "complete", "revoked", or "canceled" - if ((auditApprovalStatus.equals( - RequestStatus.COMPLETE_STRING)) || - (auditApprovalStatus.equals( - RequestStatus.REJECTED_STRING)) || - (auditApprovalStatus.equals( - RequestStatus.CANCELED_STRING))) { + if (auditApprovalStatus == RequestStatus.COMPLETE || + auditApprovalStatus == RequestStatus.REJECTED || + auditApprovalStatus == RequestStatus.CANCELED) { auditMessage = CMS.getLogMessage( LOGGING_SIGNED_AUDIT_CERT_STATUS_CHANGE_REQUEST_PROCESSED, auditSubjectID, @@ -564,7 +561,7 @@ public class DoRevokeTPS extends CMSServlet { auditSerialNumber, auditRequestType, auditReasonNum, - auditApprovalStatus); + auditApprovalStatus == null ? ILogger.SIGNED_AUDIT_EMPTY_VALUE : auditApprovalStatus.toString()); audit(auditMessage); } @@ -744,9 +741,9 @@ public class DoRevokeTPS extends CMSServlet { // store a message in the signed audit log file // if and only if "auditApprovalStatus" is // "complete", "revoked", or "canceled" - if ((auditApprovalStatus.equals(RequestStatus.COMPLETE_STRING)) - || (auditApprovalStatus.equals(RequestStatus.REJECTED_STRING)) - || (auditApprovalStatus.equals(RequestStatus.CANCELED_STRING))) { + if (auditApprovalStatus == RequestStatus.COMPLETE || + auditApprovalStatus == RequestStatus.REJECTED || + auditApprovalStatus == RequestStatus.CANCELED) { auditMessage = CMS.getLogMessage( LOGGING_SIGNED_AUDIT_CERT_STATUS_CHANGE_REQUEST_PROCESSED, auditSubjectID, @@ -755,7 +752,7 @@ public class DoRevokeTPS extends CMSServlet { auditSerialNumber, auditRequestType, auditReasonNum, - auditApprovalStatus); + auditApprovalStatus == null ? ILogger.SIGNED_AUDIT_EMPTY_VALUE : auditApprovalStatus.toString()); audit(auditMessage); } @@ -779,12 +776,9 @@ public class DoRevokeTPS extends CMSServlet { // message in the signed audit log file // if and only if "auditApprovalStatus" is // "complete", "revoked", or "canceled" - if ((auditApprovalStatus.equals( - RequestStatus.COMPLETE_STRING)) || - (auditApprovalStatus.equals( - RequestStatus.REJECTED_STRING)) || - (auditApprovalStatus.equals( - RequestStatus.CANCELED_STRING))) { + if (auditApprovalStatus == RequestStatus.COMPLETE || + auditApprovalStatus == RequestStatus.REJECTED || + auditApprovalStatus == RequestStatus.CANCELED) { auditMessage = CMS.getLogMessage( LOGGING_SIGNED_AUDIT_CERT_STATUS_CHANGE_REQUEST_PROCESSED, auditSubjectID, @@ -793,7 +787,7 @@ public class DoRevokeTPS extends CMSServlet { auditSerialNumber, auditRequestType, auditReasonNum, - auditApprovalStatus); + auditApprovalStatus == null ? ILogger.SIGNED_AUDIT_EMPTY_VALUE : auditApprovalStatus.toString()); audit(auditMessage); } @@ -821,12 +815,9 @@ public class DoRevokeTPS extends CMSServlet { // message in the signed audit log file // if and only if "auditApprovalStatus" is // "complete", "revoked", or "canceled" - if ((auditApprovalStatus.equals( - RequestStatus.COMPLETE_STRING)) || - (auditApprovalStatus.equals( - RequestStatus.REJECTED_STRING)) || - (auditApprovalStatus.equals( - RequestStatus.CANCELED_STRING))) { + if (auditApprovalStatus == RequestStatus.COMPLETE || + auditApprovalStatus == RequestStatus.REJECTED || + auditApprovalStatus == RequestStatus.CANCELED) { auditMessage = CMS.getLogMessage( LOGGING_SIGNED_AUDIT_CERT_STATUS_CHANGE_REQUEST_PROCESSED, auditSubjectID, @@ -835,7 +826,7 @@ public class DoRevokeTPS extends CMSServlet { auditSerialNumber, auditRequestType, auditReasonNum, - auditApprovalStatus); + auditApprovalStatus == null ? ILogger.SIGNED_AUDIT_EMPTY_VALUE : auditApprovalStatus.toString()); audit(auditMessage); } |