summaryrefslogtreecommitdiffstats
path: root/specs
diff options
context:
space:
mode:
authorEndi S. Dewata <edewata@redhat.com>2015-01-30 15:49:27 -0500
committerEndi S. Dewata <edewata@redhat.com>2015-02-05 11:32:20 -0500
commitdfe55982eb50750fc1e65bce312d884b1604f0b4 (patch)
tree411d1316c3b4ff78e3a349bb4923bd0e2aae03c7 /specs
parent8fc5acb72ac9fdbc70b8a6e7242890f9dbeccf56 (diff)
downloadpki-dfe55982eb50750fc1e65bce312d884b1604f0b4.tar.gz
pki-dfe55982eb50750fc1e65bce312d884b1604f0b4.tar.xz
pki-dfe55982eb50750fc1e65bce312d884b1604f0b4.zip
Fixed pylint report.
Previously pylint report was saved it into a file which may not be accessible on a build system. The pylint-build-scan.sh has been changed to display the report so it will appear in the build log. The pylint configuration has also been modified to disable C and R messages by default. This way when other errors or warnings occur the build will fail without having to check for specific codes. Some Python codes have been modified to reduce the number of pylint warnings. https://fedorahosted.org/pki/ticket/703
Diffstat (limited to 'specs')
-rw-r--r--specs/pki-core.spec6
1 files changed, 3 insertions, 3 deletions
diff --git a/specs/pki-core.spec b/specs/pki-core.spec
index 8df878cd4..a9d9db6d2 100644
--- a/specs/pki-core.spec
+++ b/specs/pki-core.spec
@@ -628,10 +628,10 @@ ln -s %{_javadir}/pki/pki-tps.jar %{buildroot}%{_datadir}/pki/tps/webapps/tps/WE
%if %{with server}
%if ! 0%{?rhel}
-# Scanning the python code with pylint. A return value of 0 represents there are no
-# errors or warnings reported by pylint.
+# Scanning the python code with pylint.
sh ../pylint-build-scan.sh %{buildroot} `pwd`
-if [ $? -eq 1 ]; then
+if [ $? -ne 0 ]; then
+ echo "pylint failed. RC: $?"
exit 1
fi
%endif