diff options
author | jdennis <jdennis@c9f7a03b-bd48-0410-a16d-cbbf54688b0b> | 2010-11-19 21:02:21 +0000 |
---|---|---|
committer | jdennis <jdennis@c9f7a03b-bd48-0410-a16d-cbbf54688b0b> | 2010-11-19 21:02:21 +0000 |
commit | 1ce12b22e224af364d62c12b690a59b5cd10851b (patch) | |
tree | 8e27be6f33e63f05acfde3fbcf4c317ed2ea2233 /pki/base/tps | |
parent | 7ff1a2d86491e3ae8bc653e2ab2cc261d10fda36 (diff) | |
download | pki-1ce12b22e224af364d62c12b690a59b5cd10851b.tar.gz pki-1ce12b22e224af364d62c12b690a59b5cd10851b.tar.xz pki-1ce12b22e224af364d62c12b690a59b5cd10851b.zip |
Fix issues discovered during testing
During testing with Ade several issues were discovered which needed
fixing, these included:
Remove connectionTimeout on JSS connectors in the server.xml files due
to JSS bug. We will reenable the timeouts when JSS is fixed.
pki_apache_initscript had chmod & chown wrapped in an echo command
which prevented them from executing, an artifact inadverantly left in
the file during a debug session. The role parameter to runcon which
had been added to facilitate test/debug was removed.
The logfile variables shared between pkicommon, pkicreate and
pkiremove were awkward and resulted in warnings about the use of
uninitialized variables in some circumstances. Some functions were
tweaked and some variables removed to enforce better data hiding and
eliminate the warnings with respect to the logfile.
If the pkicreate script aborted before it completed it would fail to
write the installation manifest which made it impossible to remove the
partial installation via pkiremove. A hander was added so it would run
if Perl executed a "die" (e.g. aborted). The handler writes the
manifest before final exit. The subroutine used to write the manifest
was bullet proofed to avoid referencing uninitialized variables in the
case of non-normal exit.
The copy_directory() subroutine failed to preserve symbolic links in
the source, instead it traversed the source link and copied the target
of the link. copy_directory() and it's support routines were enhanced
to preserve symbolic links. A new subrotine copy_symlink() was added.
pkicreate failed to create a symbolic link to the symkey.jar file, it
now creates the link to symkey.jar.
The passwords written into the two password files were not terminated
with a newline character, now they are.
pkiremove would enter an infinate loop if the -force option was
specified, this is now fixed.
The tomcat6.conf file had been inadvertantly omitted from the tks
subsystem.
References to the deprecated apachectl file were expunged.
git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1577 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
Diffstat (limited to 'pki/base/tps')
-rw-r--r-- | pki/base/tps/CMakeLists.txt | 2 | ||||
-rw-r--r-- | pki/base/tps/Makefile.am | 2 | ||||
-rw-r--r-- | pki/base/tps/Makefile.in | 1 |
3 files changed, 0 insertions, 5 deletions
diff --git a/pki/base/tps/CMakeLists.txt b/pki/base/tps/CMakeLists.txt index b97cccf56..04859aaa3 100644 --- a/pki/base/tps/CMakeLists.txt +++ b/pki/base/tps/CMakeLists.txt @@ -20,8 +20,6 @@ install( ) install( - FILES - apache/apachectl DESTINATION ${LIB_INSTALL_DIR}/${APPLICATION_NAME}/${PROJECT_NAME} PERMISSIONS diff --git a/pki/base/tps/Makefile.am b/pki/base/tps/Makefile.am index a98fd8971..9bb9d7665 100644 --- a/pki/base/tps/Makefile.am +++ b/pki/base/tps/Makefile.am @@ -188,8 +188,6 @@ initd_SCRIPTS = $(srcdir)/etc/init.d/pki-tpsd license_DATA = $(srcdir)/LICENSE -libexec_SCRIPTS = $(srcdir)/apache/apachectl - # create an empty 'logs' directory logs_DATA = diff --git a/pki/base/tps/Makefile.in b/pki/base/tps/Makefile.in index 090edfeee..2b692972c 100644 --- a/pki/base/tps/Makefile.in +++ b/pki/base/tps/Makefile.in @@ -671,7 +671,6 @@ docroot_tps_img_DATA = docroot_tps_js_DATA = initd_SCRIPTS = $(srcdir)/etc/init.d/pki-tpsd license_DATA = $(srcdir)/LICENSE -libexec_SCRIPTS = $(srcdir)/apache/apachectl # create an empty 'logs' directory logs_DATA = |