summaryrefslogtreecommitdiffstats
path: root/pki/base/common/src/com/netscape/cms/servlet/request/KeyRequestsResourceService.java
diff options
context:
space:
mode:
authorEndi Sukma Dewata <edewata@redhat.com>2012-03-14 12:51:23 -0500
committerEndi Sukma Dewata <edewata@redhat.com>2012-03-14 14:45:02 -0500
commit5c613fcb2323cb477ac6d4518a73fc4a810c2b3f (patch)
tree5e415ef33af90934c82c7d161982290d58de2331 /pki/base/common/src/com/netscape/cms/servlet/request/KeyRequestsResourceService.java
parent2c960067012c43db1437f561a63fc515328344e2 (diff)
downloadpki-5c613fcb2323cb477ac6d4518a73fc4a810c2b3f.tar.gz
pki-5c613fcb2323cb477ac6d4518a73fc4a810c2b3f.tar.xz
pki-5c613fcb2323cb477ac6d4518a73fc4a810c2b3f.zip
Escape parameter values in search filter.
The REST interface was vulnerable to injection attack. This has been fixed by escaping the special characters in parameter values before using them in the search filter. Ticket #96
Diffstat (limited to 'pki/base/common/src/com/netscape/cms/servlet/request/KeyRequestsResourceService.java')
-rw-r--r--pki/base/common/src/com/netscape/cms/servlet/request/KeyRequestsResourceService.java7
1 files changed, 4 insertions, 3 deletions
diff --git a/pki/base/common/src/com/netscape/cms/servlet/request/KeyRequestsResourceService.java b/pki/base/common/src/com/netscape/cms/servlet/request/KeyRequestsResourceService.java
index 9b11a96d6..11898ef7a 100644
--- a/pki/base/common/src/com/netscape/cms/servlet/request/KeyRequestsResourceService.java
+++ b/pki/base/common/src/com/netscape/cms/servlet/request/KeyRequestsResourceService.java
@@ -29,6 +29,7 @@ import com.netscape.certsrv.request.RequestId;
import com.netscape.cms.servlet.base.CMSResourceService;
import com.netscape.cms.servlet.request.model.KeyRequestDAO;
import com.netscape.cms.servlet.request.model.KeyRequestInfos;
+import com.netscape.cmsutil.ldap.LDAPUtil;
/**
* @author alee
@@ -77,17 +78,17 @@ public class KeyRequestsResourceService extends CMSResourceService implements Ke
}
if (requestState != null) {
- filter += "(requeststate=" + requestState + ")";
+ filter += "(requeststate=" + LDAPUtil.escape(requestState) + ")";
matches ++;
}
if (requestType != null) {
- filter += "(requesttype=" + requestType + ")";
+ filter += "(requesttype=" + LDAPUtil.escape(requestType) + ")";
matches ++;
}
if (clientID != null) {
- filter += "(clientID=" + clientID + ")";
+ filter += "(clientID=" + LDAPUtil.escape(clientID) + ")";
matches ++;
}