Fixes for Coverity Defects of Category : FB.DM_NUMBER_CTOR, FB.DM_STRING_CTOR, FB.DM_STRING_VOID_CTOR

4 files changed, 12 insertions, 13 deletions

diff --git a/base/util/src/com/netscape/cmsutil/scep/CRSPKIMessage.java b/base/util/src/com/netscape/cmsutil/scep/CRSPKIMessage.java
index 834e21088..de6cb20aa 100644
--- a/base/util/src/com/netscape/cmsutil/scep/CRSPKIMessage.java
+++ b/base/util/src/com/netscape/cmsutil/scep/CRSPKIMessage.java
@@ -855,10 +855,10 @@ public class CRSPKIMessage {
 
             } else if (oid.equals(CRS_PKISTATUS)) {
                 ps = (PrintableString) pst.decode(new ByteArrayInputStream(f.getEncoded()));
-                pkiStatus = new String(ps.toString());
+                pkiStatus = ps.toString();
             } else if (oid.equals(CRS_FAILINFO)) {
                 ps = (PrintableString) pst.decode(new ByteArrayInputStream(f.getEncoded()));
-                failInfo = new String(ps.toString());
+                failInfo = ps.toString();
             } else if (oid.equals(CRS_SENDERNONCE)) {
                 OCTET_STRING oss = (OCTET_STRING) ost.decode(new ByteArrayInputStream(f.getEncoded()));
 
@@ -869,7 +869,7 @@ public class CRSPKIMessage {
                 recipientNonce = osr.toByteArray();
             } else if (oid.equals(CRS_TRANSID)) {
                 ps = (PrintableString) pst.decode(new ByteArrayInputStream(f.getEncoded()));
-                transactionID = new String(ps.toString());
+                transactionID = ps.toString();
             }
 
         }
diff --git a/base/util/src/netscape/security/extensions/ExtendedKeyUsageExtension.java b/base/util/src/netscape/security/extensions/ExtendedKeyUsageExtension.java
index 072a7c974..7c9f8450d 100644
--- a/base/util/src/netscape/security/extensions/ExtendedKeyUsageExtension.java
+++ b/base/util/src/netscape/security/extensions/ExtendedKeyUsageExtension.java
@@ -132,18 +132,18 @@ public class ExtendedKeyUsageExtension extends Extension implements CertAttrSet
     }
 
     public String toString() {
+
         String presentation = "oid=" + ExtendedKeyUsageExtension.OID + " ";
 
         if (critical) {
             presentation += "critical=true";
         }
         if (extensionValue != null) {
-            String extByteValue = new String(" val=");
-
+            StringBuffer extByteValue = new StringBuffer(" val=");
             for (int i = 0; i < extensionValue.length; i++) {
-                extByteValue += (extensionValue[i] + " ");
+                extByteValue.append(extensionValue[i] + " ");
             }
-            presentation += extByteValue;
+            presentation += extByteValue.toString();
         }
         return presentation;
     }
diff --git a/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java b/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java
index 5295cf6a1..181360f52 100644
--- a/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java
+++ b/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java
@@ -110,7 +110,7 @@ public class InhibitAnyPolicyExtension
             presentation += "Criticality=false";
         }
         if (extensionValue != null) {
-            String extByteValue = new String(" skipCerts=" + mSkipCerts);
+            String extByteValue = " skipCerts=" + mSkipCerts;
 
             presentation += extByteValue;
         }
diff --git a/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java b/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java
index bd6cf5aa7..323cfbdbe 100644
--- a/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java
+++ b/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java
@@ -96,18 +96,17 @@ public class OCSPNoCheckExtension extends Extension implements CertAttrSet {
     }
 
     public String toString() {
-        String presentation = "oid=" + OID + " ";
+        String presentation = "oid=" + ExtendedKeyUsageExtension.OID + " ";
 
         if (critical) {
             presentation += "critical=true";
         }
         if (extensionValue != null) {
-            String extByteValue = new String(" val=");
-
+            StringBuffer extByteValue = new StringBuffer(" val=");
             for (int i = 0; i < extensionValue.length; i++) {
-                extByteValue += (extensionValue[i] + " ");
+                extByteValue.append(extensionValue[i] + " ");
             }
-            presentation += extByteValue;
+            presentation += extByteValue.toString();
         }
         return presentation;
     }