summaryrefslogtreecommitdiffstats
path: root/base/util
diff options
context:
space:
mode:
authorAbhishek Koneru <akoneru@redhat.com>2012-05-24 16:11:53 -0400
committerAde Lee <alee@redhat.com>2012-06-01 09:35:27 -0400
commit2588e04ce15d8ce932900cb7b5d75e894082db46 (patch)
tree43776fbb3fb8b9a5656d3fdee1b2da90526a0eeb /base/util
parentb6967b3b2b850e4158bd1fb6cee418e714053e30 (diff)
downloadpki-2588e04ce15d8ce932900cb7b5d75e894082db46.tar.gz
pki-2588e04ce15d8ce932900cb7b5d75e894082db46.tar.xz
pki-2588e04ce15d8ce932900cb7b5d75e894082db46.zip
Fixes for Coverity Issues CALL_SUPER,UNCONFIRMEDCAST,DEAD_STORE,TOSTRING_ARRAY
Diffstat (limited to 'base/util')
-rw-r--r--base/util/src/netscape/security/extensions/ExtendedKeyUsageExtension.java1
-rw-r--r--base/util/src/netscape/security/extensions/GenericASN1Extension.java3
-rw-r--r--base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java1
-rw-r--r--base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java1
-rw-r--r--base/util/src/netscape/security/pkcs/PKCS7.java2
-rw-r--r--base/util/src/netscape/security/x509/CRLDistributionPointsExtension.java1
-rw-r--r--base/util/src/netscape/security/x509/FreshestCRLExtension.java1
-rw-r--r--base/util/src/netscape/security/x509/IssuingDistributionPointExtension.java2
8 files changed, 9 insertions, 3 deletions
diff --git a/base/util/src/netscape/security/extensions/ExtendedKeyUsageExtension.java b/base/util/src/netscape/security/extensions/ExtendedKeyUsageExtension.java
index 391df90dc..a966ca1db 100644
--- a/base/util/src/netscape/security/extensions/ExtendedKeyUsageExtension.java
+++ b/base/util/src/netscape/security/extensions/ExtendedKeyUsageExtension.java
@@ -131,6 +131,7 @@ public class ExtendedKeyUsageExtension extends Extension implements CertAttrSet
}
}
+ @Override
public String toString() {
String presentation = "oid=" + ExtendedKeyUsageExtension.OID + " ";
diff --git a/base/util/src/netscape/security/extensions/GenericASN1Extension.java b/base/util/src/netscape/security/extensions/GenericASN1Extension.java
index d6bd01223..80617869c 100644
--- a/base/util/src/netscape/security/extensions/GenericASN1Extension.java
+++ b/base/util/src/netscape/security/extensions/GenericASN1Extension.java
@@ -270,8 +270,9 @@ public class GenericASN1Extension extends Extension
/**
* Returns a printable representation of the GenericASN1Extension.
*/
+ @Override
public String toString() {
- return (null);
+ return super.toString();
}
/**
diff --git a/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java b/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java
index 181360f52..2ccc53ffd 100644
--- a/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java
+++ b/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java
@@ -101,6 +101,7 @@ public class InhibitAnyPolicyExtension
return mSkipCerts;
}
+ @Override
public String toString() {
String presentation = "ObjectId: " + OID + " ";
diff --git a/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java b/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java
index 511255e3a..3d89e1d50 100644
--- a/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java
+++ b/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java
@@ -95,6 +95,7 @@ public class OCSPNoCheckExtension extends Extension implements CertAttrSet {
}
}
+ @Override
public String toString() {
String presentation = "oid=" + OID + " ";
diff --git a/base/util/src/netscape/security/pkcs/PKCS7.java b/base/util/src/netscape/security/pkcs/PKCS7.java
index 4bedc06fe..4ecb2966c 100644
--- a/base/util/src/netscape/security/pkcs/PKCS7.java
+++ b/base/util/src/netscape/security/pkcs/PKCS7.java
@@ -72,7 +72,7 @@ public class PKCS7 {
int len = 0;
byte[] newbuf = new byte[len];
byte[] oldbuf = new byte[len];
- byte[] data = new byte[len];
+ byte[] data;
do {
newbuf = new byte[dis.available()];
diff --git a/base/util/src/netscape/security/x509/CRLDistributionPointsExtension.java b/base/util/src/netscape/security/x509/CRLDistributionPointsExtension.java
index 327322b1c..4180473d4 100644
--- a/base/util/src/netscape/security/x509/CRLDistributionPointsExtension.java
+++ b/base/util/src/netscape/security/x509/CRLDistributionPointsExtension.java
@@ -186,6 +186,7 @@ public class CRLDistributionPointsExtension extends Extension
}
}
+ @Override
public String toString() {
return NAME;
}
diff --git a/base/util/src/netscape/security/x509/FreshestCRLExtension.java b/base/util/src/netscape/security/x509/FreshestCRLExtension.java
index b27f01a61..f108b4599 100644
--- a/base/util/src/netscape/security/x509/FreshestCRLExtension.java
+++ b/base/util/src/netscape/security/x509/FreshestCRLExtension.java
@@ -191,6 +191,7 @@ public class FreshestCRLExtension extends Extension
// because it is so complicated. Therefore, we only provide a
// minimal implementation.
/////////////////////////////////////////////////////////////
+ @Override
public String toString() {
return NAME;
}
diff --git a/base/util/src/netscape/security/x509/IssuingDistributionPointExtension.java b/base/util/src/netscape/security/x509/IssuingDistributionPointExtension.java
index b1cf61180..67ace692e 100644
--- a/base/util/src/netscape/security/x509/IssuingDistributionPointExtension.java
+++ b/base/util/src/netscape/security/x509/IssuingDistributionPointExtension.java
@@ -285,7 +285,7 @@ public class IssuingDistributionPointExtension extends Extension
/**
* Returns a printable representation of the IssuingDistributionPointExtension
*/
-
+ @Override
public String toString() {
return NAME;
}