diff options
author | Endi S. Dewata <edewata@redhat.com> | 2016-11-03 02:43:03 +0100 |
---|---|---|
committer | Endi S. Dewata <edewata@redhat.com> | 2016-11-03 03:23:03 +0100 |
commit | 44d70e078f5e5270908dd6d7a3182f48022b148d (patch) | |
tree | 3c73e2f5e5ee2660bc27266717a800685c5ab694 /base/util/src | |
parent | 487d08c2832368848f1235d781e114d343190476 (diff) | |
download | pki-44d70e078f5e5270908dd6d7a3182f48022b148d.tar.gz pki-44d70e078f5e5270908dd6d7a3182f48022b148d.tar.xz pki-44d70e078f5e5270908dd6d7a3182f48022b148d.zip |
Fixed resource leak in OCSPNoCheckExtension.
The OCSPNoCheckExtension has been modified to always close the
DerOutputStream instance.
The OCSPNoCheckExt has been modified to wrap the original
exception.
https://fedorahosted.org/pki/ticket/2530
Diffstat (limited to 'base/util/src')
-rw-r--r-- | base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java b/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java index 3d89e1d50..5952a29b8 100644 --- a/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java +++ b/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java @@ -51,11 +51,11 @@ public class OCSPNoCheckExtension extends Extension implements CertAttrSet { } } - public OCSPNoCheckExtension() { + public OCSPNoCheckExtension() throws IOException { this(Boolean.FALSE); } - public OCSPNoCheckExtension(Boolean crit) { + public OCSPNoCheckExtension(Boolean crit) throws IOException { try { extensionId = ObjectIdentifier.getObjectIdentifier(OCSPNoCheckExtension.OID); } catch (IOException e) { @@ -67,6 +67,8 @@ public class OCSPNoCheckExtension extends Extension implements CertAttrSet { try { tmpD.putNull(); } catch (IOException ex) { + } finally { + tmpD.close(); } extensionValue = tmpD.toByteArray(); } |