diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-18 16:12:17 -0400 |
---|---|---|
committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:08:51 -0400 |
commit | 9db76ed1d1f8969e93aaff320e49662f53688e2e (patch) | |
tree | 2e7af87ca0f72cdf4eb982764757d2884b21ce7b /base/util/src/netscape/security/extensions | |
parent | a4db0f39e257950a5c89203452c1184c7080e5bd (diff) | |
download | pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.gz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.xz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.zip |
Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION
Diffstat (limited to 'base/util/src/netscape/security/extensions')
3 files changed, 19 insertions, 18 deletions
diff --git a/base/util/src/netscape/security/extensions/AuthInfoAccessExtension.java b/base/util/src/netscape/security/extensions/AuthInfoAccessExtension.java index c3d2bec6c..15c56a04c 100644 --- a/base/util/src/netscape/security/extensions/AuthInfoAccessExtension.java +++ b/base/util/src/netscape/security/extensions/AuthInfoAccessExtension.java @@ -28,8 +28,6 @@ import java.security.cert.CertificateException; import java.util.Enumeration; import java.util.Vector; -import com.netscape.cmsutil.util.Utils; - import netscape.security.util.DerOutputStream; import netscape.security.util.DerValue; import netscape.security.util.ObjectIdentifier; @@ -38,6 +36,8 @@ import netscape.security.x509.Extension; import netscape.security.x509.GeneralName; import netscape.security.x509.URIName; +import com.netscape.cmsutil.util.Utils; + /** * This represents the authority information access extension * as defined in RFC2459. @@ -219,16 +219,18 @@ public class AuthInfoAccessExtension extends Extension implements CertAttrSet { * Returns a printable representation of the AuthInfoAccess. */ public String toString() { - String s = super.toString() + "AuthInfoAccess [\n"; + StringBuffer s = new StringBuffer(); + String b = super.toString() + "AuthInfoAccess [\n"; + s.append(b); for (int i = 0; i < mDesc.size(); i++) { AccessDescription ad = mDesc.elementAt(i); - s += "(" + i + ")"; - s += " "; - s += ad.getMethod().toString() + " " + ad.getLocation().toString(); + s.append("(" + i + ")"); + s.append(" "); + s.append(ad.getMethod().toString() + " " + ad.getLocation().toString()); } - return (s + "]\n"); + return (s.toString() + "]\n"); } public static void main(String[] argv) { diff --git a/base/util/src/netscape/security/extensions/CertificateScopeOfUseExtension.java b/base/util/src/netscape/security/extensions/CertificateScopeOfUseExtension.java index 271bd3606..0f93c2b78 100644 --- a/base/util/src/netscape/security/extensions/CertificateScopeOfUseExtension.java +++ b/base/util/src/netscape/security/extensions/CertificateScopeOfUseExtension.java @@ -183,15 +183,15 @@ public class CertificateScopeOfUseExtension extends Extension * Returns a printable representation of the CertificateRenewalWindow. */ public String toString() { - String s = super.toString() + "CertificateUseOfScope [\n"; + StringBuffer s = new StringBuffer(super.toString() + "CertificateUseOfScope [\n"); if (mEntries != null) { for (int i = 0; i < mEntries.size(); i++) { CertificateScopeEntry se = mEntries.elementAt(i); - s += se.toString(); + s.append(se.toString()); } } - return (s + "]\n"); + return (s.toString() + "]\n"); } } diff --git a/base/util/src/netscape/security/extensions/SubjectInfoAccessExtension.java b/base/util/src/netscape/security/extensions/SubjectInfoAccessExtension.java index b11c77634..72407d62e 100644 --- a/base/util/src/netscape/security/extensions/SubjectInfoAccessExtension.java +++ b/base/util/src/netscape/security/extensions/SubjectInfoAccessExtension.java @@ -28,8 +28,6 @@ import java.security.cert.CertificateException; import java.util.Enumeration; import java.util.Vector; -import com.netscape.cmsutil.util.Utils; - import netscape.security.util.DerOutputStream; import netscape.security.util.DerValue; import netscape.security.util.ObjectIdentifier; @@ -38,6 +36,8 @@ import netscape.security.x509.Extension; import netscape.security.x509.GeneralName; import netscape.security.x509.URIName; +import com.netscape.cmsutil.util.Utils; + /** * This represents the subject information access extension * as defined in RFC3280. @@ -201,16 +201,15 @@ public class SubjectInfoAccessExtension extends Extension implements CertAttrSet * Returns a printable representation of the AuthInfoAccess. */ public String toString() { - String s = super.toString() + "AuthInfoAccess [\n"; + StringBuffer s=new StringBuffer(super.toString() + "AuthInfoAccess [\n"); for (int i = 0; i < mDesc.size(); i++) { AccessDescription ad = mDesc.elementAt(i); - - s += "(" + i + ")"; - s += " "; - s += ad.getMethod().toString() + " " + ad.getLocation().toString(); + s.append( "(" + i + ")"); + s.append(" "); + s.append(ad.getMethod().toString() + " " + ad.getLocation().toString()); } - return (s + "]\n"); + return (s.toString() + "]\n"); } public static void main(String[] argv) { |