summaryrefslogtreecommitdiffstats
path: root/base/util/src/com/netscape/cmsutil/password/PlainPasswordFile.java
diff options
context:
space:
mode:
authorAbhishek Koneru <akoneru@redhat.com>2012-06-20 13:56:57 -0400
committerEndi Sukma Dewata <edewata@redhat.com>2012-06-25 13:38:26 -0500
commit8a8436f73d4c4edd10b43313b724f32ccb7b957e (patch)
tree657c8f9accd34d286acf0569f768c72684a12b75 /base/util/src/com/netscape/cmsutil/password/PlainPasswordFile.java
parentde3aaef15e9b1f192344019f52d6c80860055b5e (diff)
downloadpki-8a8436f73d4c4edd10b43313b724f32ccb7b957e.tar.gz
pki-8a8436f73d4c4edd10b43313b724f32ccb7b957e.tar.xz
pki-8a8436f73d4c4edd10b43313b724f32ccb7b957e.zip
Fixes for Coverity issues of type Resource Leaks - Remaining
Diffstat (limited to 'base/util/src/com/netscape/cmsutil/password/PlainPasswordFile.java')
-rw-r--r--base/util/src/com/netscape/cmsutil/password/PlainPasswordFile.java25
1 files changed, 18 insertions, 7 deletions
diff --git a/base/util/src/com/netscape/cmsutil/password/PlainPasswordFile.java b/base/util/src/com/netscape/cmsutil/password/PlainPasswordFile.java
index adad6ee37..990d0c156 100644
--- a/base/util/src/com/netscape/cmsutil/password/PlainPasswordFile.java
+++ b/base/util/src/com/netscape/cmsutil/password/PlainPasswordFile.java
@@ -37,10 +37,15 @@ public class PlainPasswordFile implements IPasswordStore {
mPwdStore = new Properties();
// initialize mPwdStore
mPwdPath = pwdPath;
-
- FileInputStream file = new FileInputStream(mPwdPath);
- mPwdStore.load(file);
- file.close();
+ FileInputStream file = null;
+ try {
+ file = new FileInputStream(mPwdPath);
+ mPwdStore.load(file);
+ } finally {
+ if (file != null) {
+ file.close();
+ }
+ }
}
public String getPassword(String tag) {
@@ -63,8 +68,14 @@ public class PlainPasswordFile implements IPasswordStore {
public void commit()
throws IOException, ClassCastException, NullPointerException {
- FileOutputStream file = new FileOutputStream(mPwdPath);
- mPwdStore.store(file, PASSWORD_WRITER_HEADER);
- file.close();
+ FileOutputStream file = null;
+ try {
+ file = new FileOutputStream(mPwdPath);
+ mPwdStore.store(file, PASSWORD_WRITER_HEADER);
+ } finally {
+ if (file != null) {
+ file.close();
+ }
+ }
}
}