diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-18 16:12:17 -0400 |
---|---|---|
committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:08:51 -0400 |
commit | 9db76ed1d1f8969e93aaff320e49662f53688e2e (patch) | |
tree | 2e7af87ca0f72cdf4eb982764757d2884b21ce7b /base/util/src/com/netscape/cmsutil/crypto | |
parent | a4db0f39e257950a5c89203452c1184c7080e5bd (diff) | |
download | pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.gz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.xz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.zip |
Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION
Diffstat (limited to 'base/util/src/com/netscape/cmsutil/crypto')
-rw-r--r-- | base/util/src/com/netscape/cmsutil/crypto/CryptoUtil.java | 28 |
1 files changed, 15 insertions, 13 deletions
diff --git a/base/util/src/com/netscape/cmsutil/crypto/CryptoUtil.java b/base/util/src/com/netscape/cmsutil/crypto/CryptoUtil.java index c8402b2ca..65e5ad9b3 100644 --- a/base/util/src/com/netscape/cmsutil/crypto/CryptoUtil.java +++ b/base/util/src/com/netscape/cmsutil/crypto/CryptoUtil.java @@ -403,19 +403,20 @@ public class CryptoUtil { * formats a cert request */ public static String reqFormat(String content) { - String result = CERTREQ_BEGIN_HEADING + "\n"; + StringBuffer result = new StringBuffer(); + result.append(CERTREQ_BEGIN_HEADING + System.getProperty("line.separator")); while (content.length() >= LINE_COUNT) { - result = result + content.substring(0, LINE_COUNT) + "\n"; + result.append(content.substring(0, LINE_COUNT) + System.getProperty("line.separator")); content = content.substring(LINE_COUNT); } if (content.length() > 0) { - result = result + content + "\n" + CERTREQ_END_HEADING; + result.append(content).append(System.getProperty("line.separator") + CERTREQ_END_HEADING); } else { - result = result + CERTREQ_END_HEADING; + result.append(CERTREQ_END_HEADING); } - return result; + return result.toString(); } public static String getPKCS10FromKey(String dn, @@ -463,19 +464,20 @@ public class CryptoUtil { if (content == null || content.length() == 0) { return ""; } - String result = CERT_BEGIN_HEADING + "\n"; + StringBuffer result = new StringBuffer(); + result.append(CERT_BEGIN_HEADING + System.getProperty("line.separator")); while (content.length() >= LINE_COUNT) { - result = result + content.substring(0, LINE_COUNT) + "\n"; + result.append(content.substring(0, LINE_COUNT) + System.getProperty("line.separator")); content = content.substring(LINE_COUNT); } if (content.length() > 0) { - result = result + content + "\n" + CERT_END_HEADING; + result.append(content + System.getProperty("line.separator") + CERT_END_HEADING); } else { - result = result + CERT_END_HEADING; + result.append(CERT_END_HEADING); } - return result; + return result.toString(); } /** @@ -545,7 +547,7 @@ public class CryptoUtil { } public static String normalizeCertStr(String s) { - String val = ""; + StringBuffer val = new StringBuffer(); for (int i = 0; i < s.length(); i++) { if (s.charAt(i) == '\n') { @@ -557,9 +559,9 @@ public class CryptoUtil { } else if (s.charAt(i) == ' ') { continue; } - val += s.charAt(i); + val.append(s.charAt(i)); } - return val; + return val.toString(); } public static void importCertificateChain(String certchain) |