diff options
| author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-23 13:46:25 -0400 |
|---|---|---|
| committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:09:24 -0400 |
| commit | 2408bec41a56378fcf942a68a1ab290464c001d7 (patch) | |
| tree | db5b4ba123c2023c854882188851a42fd35348bf /base/silent | |
| parent | be23c86db27b7f66ca16a10ae3ef3f043d1d4b27 (diff) | |
| download | pki-2408bec41a56378fcf942a68a1ab290464c001d7.tar.gz pki-2408bec41a56378fcf942a68a1ab290464c001d7.tar.xz pki-2408bec41a56378fcf942a68a1ab290464c001d7.zip | |
Patch for fixes for Review Comments
Diffstat (limited to 'base/silent')
4 files changed, 4 insertions, 9 deletions
diff --git a/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java b/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java index 2dacaabbf..9b5cf7b52 100644 --- a/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java +++ b/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java @@ -314,12 +314,11 @@ public class ComCrypto { */ public String normalizeForLDAP(String s) { - StringBuffer val = new StringBuffer(); for (int i = 0; i < s.length(); i++) { if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'n')) { - val.append(System.getProperty("line.separator") + " "); + val.append("\n" + " "); i++; continue; } else if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'r')) { @@ -338,7 +337,6 @@ public class ComCrypto { */ public String pkcs7Convertcert(String s) { - StringBuffer val = new StringBuffer(); int len = s.length(); @@ -346,7 +344,7 @@ public class ComCrypto { for (int i = 0; i < len; i = i + 64) { if (i + 64 < len) { - val.append(s.substring(i, i + 64)+System.getProperty("line.separator")); + val.append(s.substring(i, i + 64) + "\n"); } else { val.append(s.substring(i, len)); } diff --git a/base/silent/src/com/netscape/pkisilent/common/ServerInfo.java b/base/silent/src/com/netscape/pkisilent/common/ServerInfo.java index 706d4ccee..637f0c1ee 100644 --- a/base/silent/src/com/netscape/pkisilent/common/ServerInfo.java +++ b/base/silent/src/com/netscape/pkisilent/common/ServerInfo.java @@ -243,7 +243,6 @@ public class ServerInfo { } private String stripSpace(String s) { - StringBuffer val = new StringBuffer(); for (int i = 0; i < s.length(); i++) { diff --git a/base/silent/src/com/netscape/pkisilent/common/UserEnroll.java b/base/silent/src/com/netscape/pkisilent/common/UserEnroll.java index 3f7f92791..0e31eeb57 100644 --- a/base/silent/src/com/netscape/pkisilent/common/UserEnroll.java +++ b/base/silent/src/com/netscape/pkisilent/common/UserEnroll.java @@ -299,7 +299,6 @@ public class UserEnroll extends TestClient { } private void buildquery() throws UnsupportedEncodingException { - StringBuffer queryStrBuf = new StringBuffer(); if (certType.equals("client")) { diff --git a/base/silent/src/com/netscape/pkisilent/common/Utilities.java b/base/silent/src/com/netscape/pkisilent/common/Utilities.java index 08c96e194..23fd2c54e 100644 --- a/base/silent/src/com/netscape/pkisilent/common/Utilities.java +++ b/base/silent/src/com/netscape/pkisilent/common/Utilities.java @@ -38,7 +38,6 @@ public class Utilities { } public String cleanupQuotes(String token) { - StringBuffer buf = new StringBuffer(); int length = token.length(); int curIndex = 0; @@ -141,7 +140,7 @@ public class Utilities { for (int i = 0; i < s.length(); i++) { if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'n')) { - val.append(System.getProperty("line.separator")); + val.append("\n"); i++; continue; } else if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'r')) { @@ -327,7 +326,7 @@ public class Utilities { RDN[] rdns = dname.getNames(); for (int i = rdns.length - 1; i >= 0; i--) { - pp.append(rdns[i] + System.getProperty("line.separator")); + pp.append(rdns[i] + "\n"); } cr.subject = pp.toString(); |