diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-18 17:59:50 -0400 |
---|---|---|
committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:09:10 -0400 |
commit | be23c86db27b7f66ca16a10ae3ef3f043d1d4b27 (patch) | |
tree | ba5ed1bbe24889b7d22278093ee66cffc780b42b /base/silent/src/com/netscape/pkisilent/argparser/ArgParser.java | |
parent | 9db76ed1d1f8969e93aaff320e49662f53688e2e (diff) | |
download | pki-be23c86db27b7f66ca16a10ae3ef3f043d1d4b27.tar.gz pki-be23c86db27b7f66ca16a10ae3ef3f043d1d4b27.tar.xz pki-be23c86db27b7f66ca16a10ae3ef3f043d1d4b27.zip |
Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION --Remaining
Diffstat (limited to 'base/silent/src/com/netscape/pkisilent/argparser/ArgParser.java')
-rwxr-xr-x | base/silent/src/com/netscape/pkisilent/argparser/ArgParser.java | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/base/silent/src/com/netscape/pkisilent/argparser/ArgParser.java b/base/silent/src/com/netscape/pkisilent/argparser/ArgParser.java index 29c1c394d..0e3325005 100755 --- a/base/silent/src/com/netscape/pkisilent/argparser/ArgParser.java +++ b/base/silent/src/com/netscape/pkisilent/argparser/ArgParser.java @@ -2009,7 +2009,7 @@ public class ArgParser { s = "Usage: " + synopsisString + "\n"; s += "Options include:\n\n"; for (int i = 0; i < matchList.size(); i++) { - String optionInfo = ""; + StringBuffer optionInfo = new StringBuffer(); rec = matchList.get(i); if (rec.convertCode == 'h' && !helpOptionsEnabled) { continue; @@ -2021,33 +2021,33 @@ public class ArgParser { } } for (ndesc = rec.nameList; ndesc != null; ndesc = ndesc.next) { - optionInfo += ndesc.name; + optionInfo.append(ndesc.name); if (hasOneWordAlias && !ndesc.oneWord) { - optionInfo += " "; + optionInfo.append(" "); } if (ndesc.next != null) { - optionInfo += ","; + optionInfo.append(","); } } if (!hasOneWordAlias) { - optionInfo += " "; + optionInfo.append(" "); } if (rec.convertCode != 'v' && rec.convertCode != 'h') { if (rec.valueDesc != null) { - optionInfo += rec.valueDesc; + optionInfo.append(rec.valueDesc); } else { if (rec.rangeDesc != null) { - optionInfo += "<" + rec.valTypeName() + " " - + rec.rangeDesc + ">"; + optionInfo.append("<" + rec.valTypeName() + " " + + rec.rangeDesc + ">"); } else { - optionInfo += "<" + rec.valTypeName() + ">"; + optionInfo.append("<" + rec.valTypeName() + ">"); } } } if (rec.numValues > 1) { - optionInfo += "X" + rec.numValues; + optionInfo.append("X" + rec.numValues); } - s += optionInfo; + s += optionInfo.toString(); if (rec.helpMsg.length() > 0) { int pad = helpIndent - optionInfo.length(); if (pad < 2) { //s += '\n'; |