In-tree tests and linting with tox

Before the patch it wasn't possible to run pylint outside a RPM build.
The Python sources were split into common and server files in two
separate trees. With setup.py and tox the pki package can now be
installed and tested in a virtual env.

Tox enables developers to automate installation and testing in Python
virtual environment. The new tox.ini performs several tasks with one
command:

 * It creates and installs a source distribution of pki packages and its
   command line scripts
 * It verifies that all CLI scripts can be execute (using its --help
   argument).
 * It runs pylint on all Python files and CLI scripts.
 * It can run flake8 on all Python and CLI files (disabled for now).
 * Finally it builds Sphinx autodocs.

I had to delay the root check in pkispawn and pkidestroy and modify two
files to get rid of Sphinx warnings.

https://fedorahosted.org/pki/ticket/696
http://tox.readthedocs.org

2 files changed, 8 insertions, 8 deletions

diff --git a/base/server/sbin/pkidestroy b/base/server/sbin/pkidestroy
index c2eb91a5a..abc11dc8d 100755
--- a/base/server/sbin/pkidestroy
+++ b/base/server/sbin/pkidestroy
@@ -63,10 +63,6 @@ def main(argv):
 
     config.pki_deployment_executable = os.path.basename(argv[0])
 
-    # Only run this program as "root".
-    if not os.geteuid() == 0:
-        sys.exit("'%s' must be run as root!" % argv[0])
-
     # Set the umask
     os.umask(config.PKI_DEPLOYMENT_DEFAULT_UMASK)
 
@@ -130,6 +126,10 @@ def main(argv):
 
     interactive = False
 
+    # Only run this program as "root".
+    if not os.geteuid() == 0:
+        sys.exit("'%s' must be run as root!" % argv[0])
+
     while True:
 
         # -s <subsystem>
diff --git a/base/server/sbin/pkispawn b/base/server/sbin/pkispawn
index bebbf0b77..fb5a61a8f 100755
--- a/base/server/sbin/pkispawn
+++ b/base/server/sbin/pkispawn
@@ -66,10 +66,6 @@ def main(argv):
 
     config.pki_deployment_executable = os.path.basename(argv[0])
 
-    # Only run this program as "root".
-    if not os.geteuid() == 0:
-        sys.exit("'%s' must be run as root!" % argv[0])
-
     # Set the umask
     os.umask(config.PKI_DEPLOYMENT_DEFAULT_UMASK)
 
@@ -130,6 +126,10 @@ def main(argv):
         parser.indent = 0
         print log.PKISPAWN_INTERACTIVE_INSTALLATION
 
+    # Only run this program as "root".
+    if not os.geteuid() == 0:
+        sys.exit("'%s' must be run as root!" % argv[0])
+
     while True:
         # -s <subsystem>
         if args.pki_subsystem is None: