diff options
| author | Endi S. Dewata <edewata@redhat.com> | 2015-01-30 15:49:27 -0500 |
|---|---|---|
| committer | Endi S. Dewata <edewata@redhat.com> | 2015-02-05 11:32:20 -0500 |
| commit | dfe55982eb50750fc1e65bce312d884b1604f0b4 (patch) | |
| tree | 411d1316c3b4ff78e3a349bb4923bd0e2aae03c7 /base/server/sbin | |
| parent | 8fc5acb72ac9fdbc70b8a6e7242890f9dbeccf56 (diff) | |
| download | pki-dfe55982eb50750fc1e65bce312d884b1604f0b4.tar.gz pki-dfe55982eb50750fc1e65bce312d884b1604f0b4.tar.xz pki-dfe55982eb50750fc1e65bce312d884b1604f0b4.zip | |
Fixed pylint report.
Previously pylint report was saved it into a file which may not be
accessible on a build system. The pylint-build-scan.sh has been
changed to display the report so it will appear in the build log.
The pylint configuration has also been modified to disable C and R
messages by default. This way when other errors or warnings occur
the build will fail without having to check for specific codes.
Some Python codes have been modified to reduce the number of pylint
warnings.
https://fedorahosted.org/pki/ticket/703
Diffstat (limited to 'base/server/sbin')
| -rwxr-xr-x | base/server/sbin/pki-server-upgrade | 2 | ||||
| -rwxr-xr-x | base/server/sbin/pkidestroy | 2 | ||||
| -rwxr-xr-x | base/server/sbin/pkispawn | 10 |
3 files changed, 7 insertions, 7 deletions
diff --git a/base/server/sbin/pki-server-upgrade b/base/server/sbin/pki-server-upgrade index 212fc2675..d149bc045 100755 --- a/base/server/sbin/pki-server-upgrade +++ b/base/server/sbin/pki-server-upgrade @@ -28,7 +28,7 @@ import pki.upgrade import pki.server.upgrade -# pylint: disable-msg=W0613 +# pylint: disable=W0613 def interrupt_handler(event, frame): print print diff --git a/base/server/sbin/pkidestroy b/base/server/sbin/pkidestroy index f0fa27a00..dbd658a20 100755 --- a/base/server/sbin/pkidestroy +++ b/base/server/sbin/pkidestroy @@ -50,7 +50,7 @@ error was: #Handle the Keyboard Interrupt -# pylint: disable-msg=W0613 +# pylint: disable=W0613 def interrupt_handler(event, frame): print print '\nUninstallation canceled.' diff --git a/base/server/sbin/pkispawn b/base/server/sbin/pkispawn index 04eec6ab9..45789fe87 100755 --- a/base/server/sbin/pkispawn +++ b/base/server/sbin/pkispawn @@ -53,7 +53,7 @@ error was: # Handle the Keyboard Interrupt -# pylint: disable-msg=W0613 +# pylint: disable=W0613 def interrupt_handler(event, frame): print print '\nInstallation canceled.' @@ -505,7 +505,7 @@ def main(argv): instance = scriptlet.PkiScriptlet() try: rv = instance.spawn(deployer) - # pylint: disable-msg=W0703 + # pylint: disable=W0703 except Exception: log_error_details() print @@ -546,9 +546,9 @@ def print_install_information(mdict): % mdict['pki_client_database_dir'] print log.PKI_CHECK_STATUS_MESSAGE % mdict['pki_instance_name'] print log.PKI_INSTANCE_RESTART_MESSAGE % mdict['pki_instance_name'] - if (((config.pki_subsystem == "KRA" or - config.pki_subsystem == "OCSP") and - config.str2bool(mdict['pki_standalone'])) and + if (((config.pki_subsystem == "KRA" or\ + config.pki_subsystem == "OCSP") and\ + config.str2bool(mdict['pki_standalone'])) and\ not config.str2bool(mdict['pki_external_step_two'])): # Stand-alone PKI KRA/OCSP (External CA Step 1) print log.PKI_CONFIGURATION_STANDALONE_1 % config.pki_subsystem |