diff options
author | Christian Heimes <cheimes@redhat.com> | 2015-07-01 13:15:30 +0200 |
---|---|---|
committer | Christian Heimes <cheimes@redhat.com> | 2015-07-10 10:35:54 +0200 |
commit | 597bf54f3e999867a3e42686b3063b169b52018c (patch) | |
tree | 30556ee484a2ff3eb931c92d0f0fad130f35aa72 /base/server/sbin/pkidestroy | |
parent | fa302897b3e97d78b925e8ee763c822a1169f07a (diff) | |
download | pki-597bf54f3e999867a3e42686b3063b169b52018c.tar.gz pki-597bf54f3e999867a3e42686b3063b169b52018c.tar.xz pki-597bf54f3e999867a3e42686b3063b169b52018c.zip |
In-tree tests and linting with tox
Before the patch it wasn't possible to run pylint outside a RPM build.
The Python sources were split into common and server files in two
separate trees. With setup.py and tox the pki package can now be
installed and tested in a virtual env.
Tox enables developers to automate installation and testing in Python
virtual environment. The new tox.ini performs several tasks with one
command:
* It creates and installs a source distribution of pki packages and its
command line scripts
* It verifies that all CLI scripts can be execute (using its --help
argument).
* It runs pylint on all Python files and CLI scripts.
* It can run flake8 on all Python and CLI files (disabled for now).
* Finally it builds Sphinx autodocs.
I had to delay the root check in pkispawn and pkidestroy and modify two
files to get rid of Sphinx warnings.
https://fedorahosted.org/pki/ticket/696
http://tox.readthedocs.org
Diffstat (limited to 'base/server/sbin/pkidestroy')
-rwxr-xr-x | base/server/sbin/pkidestroy | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/base/server/sbin/pkidestroy b/base/server/sbin/pkidestroy index c2eb91a5a..abc11dc8d 100755 --- a/base/server/sbin/pkidestroy +++ b/base/server/sbin/pkidestroy @@ -63,10 +63,6 @@ def main(argv): config.pki_deployment_executable = os.path.basename(argv[0]) - # Only run this program as "root". - if not os.geteuid() == 0: - sys.exit("'%s' must be run as root!" % argv[0]) - # Set the umask os.umask(config.PKI_DEPLOYMENT_DEFAULT_UMASK) @@ -130,6 +126,10 @@ def main(argv): interactive = False + # Only run this program as "root". + if not os.geteuid() == 0: + sys.exit("'%s' must be run as root!" % argv[0]) + while True: # -s <subsystem> |