Added more null parameter checking.

Some REST methods have been modified to check for null parameters
and return the proper error code.

Ticket #749

2 files changed, 7 insertions, 0 deletions

diff --git a/base/server/cmscore/src/com/netscape/cmscore/logging/AuditService.java b/base/server/cmscore/src/com/netscape/cmscore/logging/AuditService.java
index 89ac6263e..1d07114b1 100644
--- a/base/server/cmscore/src/com/netscape/cmscore/logging/AuditService.java
+++ b/base/server/cmscore/src/com/netscape/cmscore/logging/AuditService.java
@@ -35,6 +35,7 @@ import org.apache.commons.lang.StringUtils;
 import org.jboss.resteasy.plugins.providers.atom.Link;
 
 import com.netscape.certsrv.apps.CMS;
+import com.netscape.certsrv.base.BadRequestException;
 import com.netscape.certsrv.base.EBaseException;
 import com.netscape.certsrv.base.IConfigStore;
 import com.netscape.certsrv.base.PKIException;
@@ -116,6 +117,8 @@ public class AuditService extends PKIService implements AuditResource {
     @Override
     public Response updateAuditConfig(AuditConfig auditConfig) {
 
+        if (auditConfig == null) throw new BadRequestException("Audit config is null.");
+
         CMS.debug("AuditService.updateAuditConfig()");
 
         try {
diff --git a/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestService.java b/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestService.java
index 4fcddb7e4..bd02b6752 100644
--- a/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestService.java
+++ b/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestService.java
@@ -141,6 +141,8 @@ public class SelfTestService extends PKIService implements SelfTestResource {
     @Override
     public SelfTestData getSelfTest(String selfTestID) {
 
+        if (selfTestID == null) throw new BadRequestException("Self test ID is null.");
+
         CMS.debug("SelfTestService.getSelfTest(\"" + selfTestID + "\")");
 
         try {
@@ -156,6 +158,8 @@ public class SelfTestService extends PKIService implements SelfTestResource {
     @Override
     public void executeSelfTests(String action) {
 
+        if (action == null) throw new BadRequestException("Action is null.");
+
         CMS.debug("SelfTestService.executeSelfTests(\"" + action + "\")");
 
         if (!"run".equals(action)) {