diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-18 17:59:50 -0400 |
---|---|---|
committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:09:10 -0400 |
commit | be23c86db27b7f66ca16a10ae3ef3f043d1d4b27 (patch) | |
tree | ba5ed1bbe24889b7d22278093ee66cffc780b42b /base/kra/src/com/netscape/kra/EnrollmentService.java | |
parent | 9db76ed1d1f8969e93aaff320e49662f53688e2e (diff) | |
download | pki-be23c86db27b7f66ca16a10ae3ef3f043d1d4b27.tar.gz pki-be23c86db27b7f66ca16a10ae3ef3f043d1d4b27.tar.xz pki-be23c86db27b7f66ca16a10ae3ef3f043d1d4b27.zip |
Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION --Remaining
Diffstat (limited to 'base/kra/src/com/netscape/kra/EnrollmentService.java')
-rw-r--r-- | base/kra/src/com/netscape/kra/EnrollmentService.java | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/base/kra/src/com/netscape/kra/EnrollmentService.java b/base/kra/src/com/netscape/kra/EnrollmentService.java index 22400cf67..c881decdf 100644 --- a/base/kra/src/com/netscape/kra/EnrollmentService.java +++ b/base/kra/src/com/netscape/kra/EnrollmentService.java @@ -834,7 +834,7 @@ public class EnrollmentService implements IService { return ILogger.SIGNED_AUDIT_EMPTY_VALUE; } - String key = ""; + StringBuffer key = new StringBuffer(); // convert "rawData" into "base64Data" if (rawData != null) { @@ -845,16 +845,14 @@ public class EnrollmentService implements IService { // extract all line separators from the "base64Data" StringTokenizer st = new StringTokenizer(base64Data, "\r\n"); while (st.hasMoreTokens()) { - key += st.nextToken(); + key.append(st.nextToken()); } } - - key = key.trim(); - - if (key.equals("")) { + String checkKey = key.toString().trim(); + if (checkKey.equals("")) { return ILogger.SIGNED_AUDIT_EMPTY_VALUE; } else { - return key; + return checkKey; } } |