diff options
author | Matthew Harmsen <mharmsen@redhat.com> | 2014-04-16 18:38:10 -0700 |
---|---|---|
committer | Matthew Harmsen <mharmsen@redhat.com> | 2014-04-17 11:24:50 -0700 |
commit | 611419fcd8a19c06ca651add93deb66bdd0c55d5 (patch) | |
tree | 4c2ca4e4f2253556aa08f38f27e215f78a1c1383 /base/java-tools/src/com/netscape/cmstools/tps | |
parent | 7c7cbb84f1c43ce3fbe33676f3e0f07fb7ecc2f9 (diff) | |
download | pki-611419fcd8a19c06ca651add93deb66bdd0c55d5.tar.gz pki-611419fcd8a19c06ca651add93deb66bdd0c55d5.tar.xz pki-611419fcd8a19c06ca651add93deb66bdd0c55d5.zip |
CLI argument parsing and bad return codes
* PKI TRAC Ticket #843 - Incorrect CLI argument parsing
* PKI TRAC Ticket #918 - CLI commands does not return code '1' for the failures
Diffstat (limited to 'base/java-tools/src/com/netscape/cmstools/tps')
29 files changed, 211 insertions, 0 deletions
diff --git a/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorAddCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorAddCLI.java index 59ec2f785..43a58c85c 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorAddCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorAddCLI.java @@ -22,6 +22,7 @@ import java.io.BufferedReader; import java.io.FileReader; import java.io.PrintWriter; import java.io.StringWriter; +import java.util.Arrays; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.Option; @@ -48,6 +49,13 @@ public class AuthenticatorAddCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" prior to parsing due to required option + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + Option option = new Option(null, "input", true, "Input file containing authenticator properties."); option.setArgName("file"); option.setRequired(true); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorFindCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorFindCLI.java index 552fc3040..4441bcd24 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorFindCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorFindCLI.java @@ -65,6 +65,12 @@ public class AuthenticatorFindCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); String filter = cmdArgs.length > 0 ? cmdArgs[0] : null; diff --git a/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorModifyCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorModifyCLI.java index 0f82d1e55..10e2a5e7d 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorModifyCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorModifyCLI.java @@ -67,6 +67,12 @@ public class AuthenticatorModifyCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); if (cmdArgs.length != 1) { diff --git a/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorRemoveCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorRemoveCLI.java index 6d565bc96..02bf1b1e6 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorRemoveCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorRemoveCLI.java @@ -18,6 +18,8 @@ package com.netscape.cmstools.tps.authenticator; +import java.util.Arrays; + import com.netscape.cmstools.cli.CLI; import com.netscape.cmstools.cli.MainCLI; @@ -39,6 +41,13 @@ public class AuthenticatorRemoveCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + if (args.length != 1) { printHelp(); System.exit(1); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorShowCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorShowCLI.java index af1290aa0..65e3d67d1 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorShowCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/authenticator/AuthenticatorShowCLI.java @@ -61,6 +61,12 @@ public class AuthenticatorShowCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); if (cmdArgs.length != 1) { diff --git a/base/java-tools/src/com/netscape/cmstools/tps/cert/TPSCertFindCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/cert/TPSCertFindCLI.java index 91c460bf6..a57ab6330 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/cert/TPSCertFindCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/cert/TPSCertFindCLI.java @@ -65,6 +65,12 @@ public class TPSCertFindCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); String filter = cmdArgs.length > 0 ? cmdArgs[0] : null; diff --git a/base/java-tools/src/com/netscape/cmstools/tps/cert/TPSCertShowCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/cert/TPSCertShowCLI.java index b20e9a6cc..23efd6753 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/cert/TPSCertShowCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/cert/TPSCertShowCLI.java @@ -18,6 +18,8 @@ package com.netscape.cmstools.tps.cert; +import java.util.Arrays; + import com.netscape.certsrv.tps.cert.TPSCertData; import com.netscape.cmstools.cli.CLI; import com.netscape.cmstools.cli.MainCLI; @@ -40,6 +42,13 @@ public class TPSCertShowCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + if (args.length != 1) { printHelp(); System.exit(1); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/config/ConfigModifyCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/config/ConfigModifyCLI.java index fb7e2f09f..066547181 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/config/ConfigModifyCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/config/ConfigModifyCLI.java @@ -23,6 +23,7 @@ import java.io.FileReader; import java.io.FileWriter; import java.io.PrintWriter; import java.io.StringWriter; +import java.util.Arrays; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.Option; @@ -49,6 +50,13 @@ public class ConfigModifyCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" prior to parsing due to required option + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + Option option = new Option(null, "input", true, "Input file containing general properties."); option.setArgName("file"); option.setRequired(true); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/config/ConfigShowCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/config/ConfigShowCLI.java index 33bc781ac..c04d6f58d 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/config/ConfigShowCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/config/ConfigShowCLI.java @@ -61,6 +61,12 @@ public class ConfigShowCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); if (cmdArgs.length != 0) { diff --git a/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionAddCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionAddCLI.java index 5b9cf8781..eb49fcb70 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionAddCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionAddCLI.java @@ -22,6 +22,7 @@ import java.io.BufferedReader; import java.io.FileReader; import java.io.PrintWriter; import java.io.StringWriter; +import java.util.Arrays; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.Option; @@ -48,6 +49,13 @@ public class ConnectionAddCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" prior to parsing due to required option + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + Option option = new Option(null, "input", true, "Input file containing connection properties."); option.setArgName("file"); option.setRequired(true); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionFindCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionFindCLI.java index 9d2165ef0..ad4ac0062 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionFindCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionFindCLI.java @@ -65,6 +65,12 @@ public class ConnectionFindCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); String filter = cmdArgs.length > 0 ? cmdArgs[0] : null; diff --git a/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionModifyCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionModifyCLI.java index 4c1d992d8..a05261881 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionModifyCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionModifyCLI.java @@ -67,6 +67,12 @@ public class ConnectionModifyCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); if (cmdArgs.length != 1) { diff --git a/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionRemoveCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionRemoveCLI.java index 5169f23d9..00806559b 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionRemoveCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionRemoveCLI.java @@ -18,6 +18,8 @@ package com.netscape.cmstools.tps.connection; +import java.util.Arrays; + import com.netscape.cmstools.cli.CLI; import com.netscape.cmstools.cli.MainCLI; @@ -39,6 +41,13 @@ public class ConnectionRemoveCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + if (args.length != 1) { printHelp(); System.exit(1); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionShowCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionShowCLI.java index 455518e47..852e33070 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionShowCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/connection/ConnectionShowCLI.java @@ -61,6 +61,12 @@ public class ConnectionShowCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); if (cmdArgs.length != 1) { diff --git a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileAddCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileAddCLI.java index 503e9c54d..70e0e8c7f 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileAddCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileAddCLI.java @@ -22,6 +22,7 @@ import java.io.BufferedReader; import java.io.FileReader; import java.io.PrintWriter; import java.io.StringWriter; +import java.util.Arrays; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.Option; @@ -48,6 +49,13 @@ public class ProfileAddCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" prior to parsing due to required option + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + Option option = new Option(null, "input", true, "Input file containing profile properties."); option.setArgName("file"); option.setRequired(true); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileFindCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileFindCLI.java index 251d14d23..5f6b20c53 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileFindCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileFindCLI.java @@ -65,6 +65,12 @@ public class ProfileFindCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); String filter = cmdArgs.length > 0 ? cmdArgs[0] : null; diff --git a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingAddCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingAddCLI.java index bc0cb92f2..bf9601ead 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingAddCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingAddCLI.java @@ -22,6 +22,7 @@ import java.io.BufferedReader; import java.io.FileReader; import java.io.PrintWriter; import java.io.StringWriter; +import java.util.Arrays; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.Option; @@ -48,6 +49,13 @@ public class ProfileMappingAddCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" prior to parsing due to required option + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + Option option = new Option(null, "input", true, "Input file containing profile mapping properties."); option.setArgName("file"); option.setRequired(true); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingFindCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingFindCLI.java index e125629e6..194682002 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingFindCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingFindCLI.java @@ -65,6 +65,12 @@ public class ProfileMappingFindCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); String filter = cmdArgs.length > 0 ? cmdArgs[0] : null; diff --git a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingModifyCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingModifyCLI.java index d7c82dedd..8a4adc569 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingModifyCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingModifyCLI.java @@ -67,6 +67,12 @@ public class ProfileMappingModifyCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); if (cmdArgs.length != 1) { diff --git a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingRemoveCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingRemoveCLI.java index f64c12c83..0fa33b380 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingRemoveCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingRemoveCLI.java @@ -18,6 +18,8 @@ package com.netscape.cmstools.tps.profile; +import java.util.Arrays; + import com.netscape.cmstools.cli.CLI; import com.netscape.cmstools.cli.MainCLI; @@ -39,6 +41,13 @@ public class ProfileMappingRemoveCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + if (args.length != 1) { printHelp(); System.exit(1); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingShowCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingShowCLI.java index c715a3edc..b5820661b 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingShowCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileMappingShowCLI.java @@ -61,6 +61,12 @@ public class ProfileMappingShowCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); if (cmdArgs.length != 1) { diff --git a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileModifyCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileModifyCLI.java index 8f907ab91..523182869 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileModifyCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileModifyCLI.java @@ -67,6 +67,12 @@ public class ProfileModifyCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); if (cmdArgs.length != 1) { diff --git a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileRemoveCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileRemoveCLI.java index 20913103f..23fceb328 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileRemoveCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileRemoveCLI.java @@ -18,6 +18,8 @@ package com.netscape.cmstools.tps.profile; +import java.util.Arrays; + import com.netscape.cmstools.cli.CLI; import com.netscape.cmstools.cli.MainCLI; @@ -39,6 +41,13 @@ public class ProfileRemoveCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + if (args.length != 1) { printHelp(); System.exit(1); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileShowCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileShowCLI.java index 7c4c2fa1e..37d1ed40d 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileShowCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/profile/ProfileShowCLI.java @@ -61,6 +61,12 @@ public class ProfileShowCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); if (cmdArgs.length != 1) { diff --git a/base/java-tools/src/com/netscape/cmstools/tps/token/TokenAddCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/token/TokenAddCLI.java index bb9d452a5..396dbc63f 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/token/TokenAddCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/token/TokenAddCLI.java @@ -18,6 +18,8 @@ package com.netscape.cmstools.tps.token; +import java.util.Arrays; + import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.Option; @@ -43,6 +45,13 @@ public class TokenAddCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" prior to parsing due to required option + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + Option option = new Option(null, "user", true, "User ID"); option.setArgName("User ID"); option.setRequired(true); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/token/TokenFindCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/token/TokenFindCLI.java index 22fbad944..bb1a166c1 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/token/TokenFindCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/token/TokenFindCLI.java @@ -65,6 +65,12 @@ public class TokenFindCLI extends CLI { System.exit(1); } + if (cmd.hasOption("help")) { + // Display usage + printHelp(); + System.exit(0); + } + String[] cmdArgs = cmd.getArgs(); String filter = cmdArgs.length > 0 ? cmdArgs[0] : null; diff --git a/base/java-tools/src/com/netscape/cmstools/tps/token/TokenModifyCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/token/TokenModifyCLI.java index 28559e163..beb2373d8 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/token/TokenModifyCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/token/TokenModifyCLI.java @@ -18,6 +18,8 @@ package com.netscape.cmstools.tps.token; +import java.util.Arrays; + import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.Option; @@ -43,6 +45,13 @@ public class TokenModifyCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" prior to parsing due to required option + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + Option option = new Option(null, "user", true, "User ID"); option.setArgName("User ID"); option.setRequired(true); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/token/TokenRemoveCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/token/TokenRemoveCLI.java index f522991cb..60e5c9a90 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/token/TokenRemoveCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/token/TokenRemoveCLI.java @@ -18,6 +18,8 @@ package com.netscape.cmstools.tps.token; +import java.util.Arrays; + import com.netscape.cmstools.cli.CLI; import com.netscape.cmstools.cli.MainCLI; @@ -39,6 +41,13 @@ public class TokenRemoveCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + if (args.length != 1) { printHelp(); System.exit(1); diff --git a/base/java-tools/src/com/netscape/cmstools/tps/token/TokenShowCLI.java b/base/java-tools/src/com/netscape/cmstools/tps/token/TokenShowCLI.java index 14190ef01..65ee3209f 100644 --- a/base/java-tools/src/com/netscape/cmstools/tps/token/TokenShowCLI.java +++ b/base/java-tools/src/com/netscape/cmstools/tps/token/TokenShowCLI.java @@ -18,6 +18,8 @@ package com.netscape.cmstools.tps.token; +import java.util.Arrays; + import com.netscape.certsrv.tps.token.TokenData; import com.netscape.cmstools.cli.CLI; import com.netscape.cmstools.cli.MainCLI; @@ -40,6 +42,13 @@ public class TokenShowCLI extends CLI { public void execute(String[] args) throws Exception { + // Check for "--help" + if (Arrays.asList(args).contains("--help")) { + // Display usage + printHelp(); + System.exit(0); + } + if (args.length != 1) { printHelp(); System.exit(1); |