diff options
| author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-18 16:12:17 -0400 |
|---|---|---|
| committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:08:51 -0400 |
| commit | 9db76ed1d1f8969e93aaff320e49662f53688e2e (patch) | |
| tree | 2e7af87ca0f72cdf4eb982764757d2884b21ce7b /base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java | |
| parent | a4db0f39e257950a5c89203452c1184c7080e5bd (diff) | |
| download | pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.gz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.xz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.zip | |
Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION
Diffstat (limited to 'base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java')
| -rw-r--r-- | base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java b/base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java index fdb988dd5..a713fb5a3 100644 --- a/base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java +++ b/base/java-tools/src/com/netscape/cmstools/PrettyPrintCert.java @@ -80,7 +80,8 @@ public class PrettyPrintCert { BufferedReader inputCert = null; String encodedBASE64CertChunk = ""; - String encodedBASE64Cert = ""; + StringBuffer encodedBASE64Cert = new StringBuffer(); + byte decodedBASE64Cert[] = null; X509CertImpl cert = null; Locale aLocale = null; @@ -153,7 +154,7 @@ public class PrettyPrintCert { while ((encodedBASE64CertChunk = inputCert.readLine()) != null) { if (!(encodedBASE64CertChunk.startsWith(HEADER)) && !(encodedBASE64CertChunk.startsWith(TRAILER))) { - encodedBASE64Cert += encodedBASE64CertChunk.trim(); + encodedBASE64Cert.append(encodedBASE64CertChunk.trim()); } } } catch (IOException e) { @@ -173,7 +174,7 @@ public class PrettyPrintCert { // (5) Decode the ASCII BASE 64 certificate enclosed in the // String() object into a BINARY BASE 64 byte[] object - decodedBASE64Cert = Utils.base64decode(encodedBASE64Cert); + decodedBASE64Cert = Utils.base64decode(encodedBASE64Cert.toString()); // (6) Create an X509CertImpl() object from the BINARY BASE 64 // byte[] object |