diff options
| author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-18 16:12:17 -0400 |
|---|---|---|
| committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:08:51 -0400 |
| commit | 9db76ed1d1f8969e93aaff320e49662f53688e2e (patch) | |
| tree | 2e7af87ca0f72cdf4eb982764757d2884b21ce7b /base/java-tools/src/com/netscape/cmstools/AtoB.java | |
| parent | a4db0f39e257950a5c89203452c1184c7080e5bd (diff) | |
| download | pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.gz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.xz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.zip | |
Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION
Diffstat (limited to 'base/java-tools/src/com/netscape/cmstools/AtoB.java')
| -rw-r--r-- | base/java-tools/src/com/netscape/cmstools/AtoB.java | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/base/java-tools/src/com/netscape/cmstools/AtoB.java b/base/java-tools/src/com/netscape/cmstools/AtoB.java index e3059b0d1..51fb3cc17 100644 --- a/base/java-tools/src/com/netscape/cmstools/AtoB.java +++ b/base/java-tools/src/com/netscape/cmstools/AtoB.java @@ -61,7 +61,8 @@ public class AtoB { BufferedReader inputBlob = null; String asciiBASE64BlobChunk = ""; - String asciiBASE64Blob = ""; + StringBuffer asciiBASE64Blob = new StringBuffer(); + byte binaryBASE64Blob[] = null; FileOutputStream outputBlob = null; @@ -95,7 +96,7 @@ public class AtoB { while ((asciiBASE64BlobChunk = inputBlob.readLine()) != null) { if (!(asciiBASE64BlobChunk.startsWith(HEADER)) && !(asciiBASE64BlobChunk.startsWith(TRAILER))) { - asciiBASE64Blob += asciiBASE64BlobChunk.trim(); + asciiBASE64Blob.append(asciiBASE64BlobChunk.trim()); } } } catch (IOException e) { @@ -115,7 +116,7 @@ public class AtoB { // (5) Decode the ASCII BASE 64 blob enclosed in the // String() object into a BINARY BASE 64 byte[] object - binaryBASE64Blob = Utils.base64decode(asciiBASE64Blob); + binaryBASE64Blob = Utils.base64decode(asciiBASE64Blob.toString()); // (6) Finally, print the actual AtoB blob to the // specified output file |