summaryrefslogtreecommitdiffstats
path: root/base/common
diff options
context:
space:
mode:
authorAbhishek Koneru <akoneru@redhat.com>2012-05-29 14:53:35 -0400
committerAde Lee <alee@redhat.com>2012-06-01 09:37:01 -0400
commit500fe4441a5d458818138cc9b536c3b19ac23dc8 (patch)
treef2f8897fdbbeda4d73b728dd472ab36452f8cddd /base/common
parent2588e04ce15d8ce932900cb7b5d75e894082db46 (diff)
downloadpki-500fe4441a5d458818138cc9b536c3b19ac23dc8.tar.gz
pki-500fe4441a5d458818138cc9b536c3b19ac23dc8.tar.xz
pki-500fe4441a5d458818138cc9b536c3b19ac23dc8.zip
Patch with fixes for review comments 0529
Diffstat (limited to 'base/common')
-rw-r--r--base/common/src/com/netscape/cmscore/connector/Resender.java4
-rw-r--r--base/common/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java3
2 files changed, 4 insertions, 3 deletions
diff --git a/base/common/src/com/netscape/cmscore/connector/Resender.java b/base/common/src/com/netscape/cmscore/connector/Resender.java
index 73a399fdc..e1b19749a 100644
--- a/base/common/src/com/netscape/cmscore/connector/Resender.java
+++ b/base/common/src/com/netscape/cmscore/connector/Resender.java
@@ -216,9 +216,11 @@ public class Resender implements IResender {
RequestStatus replyStatus =
RequestStatus.fromString(replymsg.reqStatus);
int index = replymsg.reqId.lastIndexOf(':');
+ RequestId replyRequestId =
+ new RequestId(replymsg.reqId.substring(index + 1));
if (Debug.ON)
- Debug.trace("reply request id " + replymsg.reqId.substring(index + 1) +
+ Debug.trace("reply request id " + replyRequestId +
" for request " + r.getRequestId());
if (replyStatus != RequestStatus.COMPLETE) {
diff --git a/base/common/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java b/base/common/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java
index 6f5d29730..c44476dd6 100644
--- a/base/common/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java
+++ b/base/common/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java
@@ -1247,8 +1247,7 @@ public class SelfTestSubsystem
*/
public void setId(String id)
throws EBaseException {
- // strip preceding/trailing whitespace
- // from passed-in String parameters
+
if (id == null) {
log(mLogger,
CMS.getLogMessage(