Fixes for Coverity Defects of Category : FB.DM_BOOLEAN_CTOR

15 files changed, 45 insertions, 50 deletions

diff --git a/base/common/src/com/netscape/cmscore/base/ArgBlock.java b/base/common/src/com/netscape/cmscore/base/ArgBlock.java
index 889ad123e..7b7e42a0f 100644
--- a/base/common/src/com/netscape/cmscore/base/ArgBlock.java
+++ b/base/common/src/com/netscape/cmscore/base/ArgBlock.java
@@ -592,11 +592,7 @@ public class ArgBlock implements IArgBlock {
      * @return value
      */
     public Object addBooleanValue(String n, boolean v) {
-        if (v) {
-            return mArgs.put(n, new Boolean("true"));
-        } else {
-            return mArgs.put(n, new Boolean("false"));
-        }
+        return mArgs.put(n, Boolean.valueOf(v));
     }
 
     /**
diff --git a/base/common/src/com/netscape/cmscore/extensions/KeyUsage.java b/base/common/src/com/netscape/cmscore/extensions/KeyUsage.java
index 41038d898..c5487de31 100644
--- a/base/common/src/com/netscape/cmscore/extensions/KeyUsage.java
+++ b/base/common/src/com/netscape/cmscore/extensions/KeyUsage.java
@@ -194,7 +194,7 @@ public class KeyUsage implements ICMSExtension {
             try {
                 byte[] value = extension.getExtensionValue();
 
-                ext = new KeyUsageExtension(new Boolean(true), value);
+                ext = new KeyUsageExtension(Boolean.valueOf(true), value);
             } catch (IOException e) {
                 return null;
             }
diff --git a/base/common/src/com/netscape/cmscore/ldap/LdapSimpleExpression.java b/base/common/src/com/netscape/cmscore/ldap/LdapSimpleExpression.java
index 4be580cbc..9a326b25e 100644
--- a/base/common/src/com/netscape/cmscore/ldap/LdapSimpleExpression.java
+++ b/base/common/src/com/netscape/cmscore/ldap/LdapSimpleExpression.java
@@ -309,7 +309,7 @@ public class LdapSimpleExpression implements ILdapExpression {
         if (!(mVal.equalsIgnoreCase("true") || mVal.equalsIgnoreCase("false")))
             throw new ELdapException(CMS.getUserMessage("CMS_LDAP_INVALID_ATTR_VALUE",
                     mVal));
-        storedVal = new Boolean(mVal);
+        storedVal = Boolean.valueOf(mVal);
         switch (mOp) {
         case OP_EQUAL:
             result = (givenVal.equals(storedVal));
diff --git a/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnection.java b/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnection.java
index a0d9b2466..f99705e84 100644
--- a/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnection.java
+++ b/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnection.java
@@ -46,7 +46,7 @@ public class LdapAnonConnection extends LDAPConnection {
         // rebind info is also anonymous.
         boolean followReferrals = connInfo.getFollowReferrals();
 
-        setOption(LDAPv2.REFERRALS, new Boolean(followReferrals));
+        setOption(LDAPv2.REFERRALS, Boolean.valueOf(followReferrals));
 
         super.connect(connInfo.getVersion(),
                 connInfo.getHost(), connInfo.getPort(), null, null);
diff --git a/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnection.java b/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnection.java
index 1ce2eeefb..787967a5f 100644
--- a/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnection.java
+++ b/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnection.java
@@ -67,7 +67,7 @@ public class LdapBoundConnection extends LDAPConnection {
 
         boolean followReferrals = connInfo.getFollowReferrals();
 
-        setOption(LDAPv2.REFERRALS, new Boolean(followReferrals));
+        setOption(LDAPv2.REFERRALS,Boolean.valueOf(followReferrals));
         if (followReferrals &&
                 authInfo.getAuthType() != LdapAuthInfo.LDAP_AUTHTYPE_SSLCLIENTAUTH) {
             LDAPRebind rebindInfo =
diff --git a/base/common/src/com/netscape/cmscore/policy/SimpleExpression.java b/base/common/src/com/netscape/cmscore/policy/SimpleExpression.java
index 97b75fa4f..4f8f0eb9a 100644
--- a/base/common/src/com/netscape/cmscore/policy/SimpleExpression.java
+++ b/base/common/src/com/netscape/cmscore/policy/SimpleExpression.java
@@ -270,7 +270,7 @@ public class SimpleExpression implements IExpression {
         if (!(mVal.equalsIgnoreCase("true") || mVal.equalsIgnoreCase("false")))
             throw new EPolicyException(CMS.getUserMessage("CMS_POLICY_INVALID_ATTR_VALUE",
                         mVal));
-        storedVal = new Boolean(mVal);
+        storedVal = Boolean.valueOf(mVal);
         switch (mOp) {
         case OP_EQUAL:
             result = (givenVal.equals(storedVal));
diff --git a/base/common/src/com/netscape/cmscore/realm/PKIJNDIRealm.java b/base/common/src/com/netscape/cmscore/realm/PKIJNDIRealm.java
index a112cdbcc..685c1e5f4 100644
--- a/base/common/src/com/netscape/cmscore/realm/PKIJNDIRealm.java
+++ b/base/common/src/com/netscape/cmscore/realm/PKIJNDIRealm.java
@@ -3,16 +3,9 @@ package com.netscape.cmscore.realm;
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.io.InputStream;
+import java.security.Principal;
 import java.security.cert.CertificateFactory;
 import java.security.cert.X509Certificate;
-import java.security.Principal;
-
-import org.apache.catalina.Context;
-import org.apache.catalina.connector.Request;
-import org.apache.catalina.connector.Response;
-import org.apache.catalina.deploy.SecurityConstraint;
-import org.apache.catalina.realm.JNDIRealm;
-
 import java.util.Enumeration;
 import java.util.Hashtable;
 import java.util.List;
@@ -23,13 +16,19 @@ import java.util.Vector;
 import javax.naming.NamingEnumeration;
 import javax.naming.NamingException;
 import javax.naming.PartialResultException;
-import javax.naming.directory.DirContext;
 import javax.naming.directory.Attribute;
 import javax.naming.directory.Attributes;
+import javax.naming.directory.DirContext;
 import javax.naming.directory.SearchControls;
 import javax.naming.directory.SearchResult;
 import javax.servlet.http.HttpServletResponse;
 
+import org.apache.catalina.Context;
+import org.apache.catalina.connector.Request;
+import org.apache.catalina.connector.Response;
+import org.apache.catalina.deploy.SecurityConstraint;
+import org.apache.catalina.realm.JNDIRealm;
+
 /*
  *  Self contained PKI JNDI Real that overrides the standard JNDI Realm
  *
@@ -384,7 +383,7 @@ public class PKIJNDIRealm extends JNDIRealm {
             if (isEntryNegative) {
                 allowed = !allowed;
             }
-            
+
             // Our current ACLs require that every entry passes for
             // the entire ACL to pass.
             // For some reason the original code allows the negative acls (deny)
@@ -496,7 +495,7 @@ public class PKIJNDIRealm extends JNDIRealm {
             if (orIndex == -1 && andIndex == -1) {
                 boolean passed = evaluateExpression(principal, s.trim());
 
-                v.addElement(Boolean.valueOf(passed));
+                v.addElement(passed);
                 break;
 
                 // || first
@@ -504,7 +503,7 @@ public class PKIJNDIRealm extends JNDIRealm {
                 String s1 = s.substring(0, orIndex);
                 boolean passed = evaluateExpression(principal, s1.trim());
 
-                v.addElement(new Boolean(passed));
+                v.addElement(Boolean.valueOf(passed));
                 v.addElement("||");
                 s = s.substring(orIndex + 2);
                 // && first
@@ -512,7 +511,7 @@ public class PKIJNDIRealm extends JNDIRealm {
                 String s1 = s.substring(0, andIndex);
                 boolean passed = evaluateExpression(principal, s1.trim());
 
-                v.addElement(new Boolean(passed));
+                v.addElement(passed);
                 v.addElement("&&");
                 s = s.substring(andIndex + 2);
             }
diff --git a/base/common/src/com/netscape/cmscore/security/CASigningCert.java b/base/common/src/com/netscape/cmscore/security/CASigningCert.java
index 335bd9f37..8d35acf1b 100644
--- a/base/common/src/com/netscape/cmscore/security/CASigningCert.java
+++ b/base/common/src/com/netscape/cmscore/security/CASigningCert.java
@@ -153,10 +153,10 @@ public class CASigningCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
-        extension.set(KeyUsageExtension.NON_REPUDIATION, new Boolean(true));
-        extension.set(KeyUsageExtension.KEY_CERTSIGN, new Boolean(true));
-        extension.set(KeyUsageExtension.CRL_SIGN, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE,Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.NON_REPUDIATION, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.KEY_CERTSIGN, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.CRL_SIGN, Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/KRATransportCert.java b/base/common/src/com/netscape/cmscore/security/KRATransportCert.java
index 7e2e2f90d..58c269796 100644
--- a/base/common/src/com/netscape/cmscore/security/KRATransportCert.java
+++ b/base/common/src/com/netscape/cmscore/security/KRATransportCert.java
@@ -95,7 +95,7 @@ public class KRATransportCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, new Boolean(true));
+        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT,Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java b/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java
index ccbb004ce..7a980c621 100644
--- a/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java
+++ b/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java
@@ -909,49 +909,49 @@ public class KeyCertUtil {
         String sslClient = properties.getSSLClientBit();
 
         if ((sslClient != null) && (sslClient.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.SSL_CLIENT, new Boolean(true));
+            ns.set(NSCertTypeExtension.SSL_CLIENT, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String sslServer = properties.getSSLServerBit();
 
         if ((sslServer != null) && (sslServer.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.SSL_SERVER, new Boolean(true));
+            ns.set(NSCertTypeExtension.SSL_SERVER, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String sslMail = properties.getSSLMailBit();
 
         if ((sslMail != null) && (sslMail.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.EMAIL, new Boolean(true));
+            ns.set(NSCertTypeExtension.EMAIL, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String sslCA = properties.getSSLCABit();
 
         if ((sslCA != null) && (sslCA.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.SSL_CA, new Boolean(true));
+            ns.set(NSCertTypeExtension.SSL_CA, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String objectSigning = properties.getObjectSigningBit();
 
         if ((objectSigning != null) && (objectSigning.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.OBJECT_SIGNING, new Boolean(true));
+            ns.set(NSCertTypeExtension.OBJECT_SIGNING, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String mailCA = properties.getMailCABit();
 
         if ((mailCA != null) && (mailCA.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.EMAIL_CA, new Boolean(true));
+            ns.set(NSCertTypeExtension.EMAIL_CA, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String objectSigningCA = properties.getObjectSigningCABit();
 
         if ((objectSigningCA != null) && (objectSigningCA.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.OBJECT_SIGNING_CA, new Boolean(true));
+            ns.set(NSCertTypeExtension.OBJECT_SIGNING_CA, Boolean.valueOf(true));
             anyExt = true;
         }
         if (anyExt)
diff --git a/base/common/src/com/netscape/cmscore/security/OCSPSigningCert.java b/base/common/src/com/netscape/cmscore/security/OCSPSigningCert.java
index 16ca08b80..07ae9ee2f 100644
--- a/base/common/src/com/netscape/cmscore/security/OCSPSigningCert.java
+++ b/base/common/src/com/netscape/cmscore/security/OCSPSigningCert.java
@@ -131,10 +131,10 @@ public class OCSPSigningCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
-        extension.set(KeyUsageExtension.NON_REPUDIATION, new Boolean(true));
-        extension.set(KeyUsageExtension.KEY_CERTSIGN, new Boolean(true));
-        extension.set(KeyUsageExtension.CRL_SIGN, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.NON_REPUDIATION, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.KEY_CERTSIGN, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.CRL_SIGN, Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/RASigningCert.java b/base/common/src/com/netscape/cmscore/security/RASigningCert.java
index cf1de4203..51e05b5e9 100644
--- a/base/common/src/com/netscape/cmscore/security/RASigningCert.java
+++ b/base/common/src/com/netscape/cmscore/security/RASigningCert.java
@@ -101,7 +101,7 @@ public class RASigningCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/SSLCert.java b/base/common/src/com/netscape/cmscore/security/SSLCert.java
index 9dbec8abb..99b920c98 100644
--- a/base/common/src/com/netscape/cmscore/security/SSLCert.java
+++ b/base/common/src/com/netscape/cmscore/security/SSLCert.java
@@ -110,10 +110,10 @@ public class SSLCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
-        extension.set(KeyUsageExtension.NON_REPUDIATION, new Boolean(true));
-        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, new Boolean(true));
-        extension.set(KeyUsageExtension.DATA_ENCIPHERMENT, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.NON_REPUDIATION, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.DATA_ENCIPHERMENT, Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/SSLSelfSignedCert.java b/base/common/src/com/netscape/cmscore/security/SSLSelfSignedCert.java
index 328f6a86c..8cee1d155 100644
--- a/base/common/src/com/netscape/cmscore/security/SSLSelfSignedCert.java
+++ b/base/common/src/com/netscape/cmscore/security/SSLSelfSignedCert.java
@@ -105,9 +105,9 @@ public class SSLSelfSignedCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
-        //extension.set(KeyUsageExtension.NON_REPUDIATION, new Boolean(true));
-        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, Boolean.valueOf(true));
+        //extension.set(KeyUsageExtension.NON_REPUDIATION, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/SubsystemCert.java b/base/common/src/com/netscape/cmscore/security/SubsystemCert.java
index d0ce74490..5ad3e11f2 100644
--- a/base/common/src/com/netscape/cmscore/security/SubsystemCert.java
+++ b/base/common/src/com/netscape/cmscore/security/SubsystemCert.java
@@ -73,9 +73,9 @@ public class SubsystemCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
-        extension.set(KeyUsageExtension.NON_REPUDIATION, new Boolean(true));
-        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.NON_REPUDIATION, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, Boolean.valueOf(true));
         return extension;
     }
 }