summaryrefslogtreecommitdiffstats
path: root/base/common
diff options
context:
space:
mode:
authorEndi S. Dewata <edewata@redhat.com>2015-06-29 10:00:08 -0400
committerEndi S. Dewata <edewata@redhat.com>2015-07-01 14:44:26 -0400
commitf0637352f12faed2727ee6dcd4661835bf9e2c40 (patch)
treebbc7079417aa3d2a70feab43c3af4926e5346efb /base/common
parentb9e461ca8a099b4535aa916886697c6eff01e431 (diff)
downloadpki-f0637352f12faed2727ee6dcd4661835bf9e2c40.tar.gz
pki-f0637352f12faed2727ee6dcd4661835bf9e2c40.tar.xz
pki-f0637352f12faed2727ee6dcd4661835bf9e2c40.zip
Cleaned up SystemConfigService.validateRequest().
The configure() in SystemConfigService method has been modified to log only the error message in normal responses but log the full stack trace when unexpected issues occur. The validateData() in SystemConfigService has been renamed to validateRequest() for clarity. The log messages have been modified to include the invalid values entered in the request.
Diffstat (limited to 'base/common')
-rw-r--r--base/common/functional/src/com/netscape/cms/servlet/test/ConfigurationTest.java2
-rw-r--r--base/common/src/com/netscape/certsrv/system/SystemConfigClient.java2
-rw-r--r--base/common/src/com/netscape/certsrv/system/SystemConfigResource.java2
3 files changed, 3 insertions, 3 deletions
diff --git a/base/common/functional/src/com/netscape/cms/servlet/test/ConfigurationTest.java b/base/common/functional/src/com/netscape/cms/servlet/test/ConfigurationTest.java
index bf4dc8928..69994fa38 100644
--- a/base/common/functional/src/com/netscape/cms/servlet/test/ConfigurationTest.java
+++ b/base/common/functional/src/com/netscape/cms/servlet/test/ConfigurationTest.java
@@ -76,7 +76,7 @@ public class ConfigurationTest {
System.exit(1);
}
- public static void main(String args[]) throws NoSuchAlgorithmException, TokenException, IOException, InvalidBERException {
+ public static void main(String args[]) throws Exception {
String host = null;
String port = null;
String cstype = null;
diff --git a/base/common/src/com/netscape/certsrv/system/SystemConfigClient.java b/base/common/src/com/netscape/certsrv/system/SystemConfigClient.java
index 242f00531..820891580 100644
--- a/base/common/src/com/netscape/certsrv/system/SystemConfigClient.java
+++ b/base/common/src/com/netscape/certsrv/system/SystemConfigClient.java
@@ -40,7 +40,7 @@ public class SystemConfigClient extends Client {
configClient = createProxy(SystemConfigResource.class);
}
- public ConfigurationResponse configure(ConfigurationRequest data) {
+ public ConfigurationResponse configure(ConfigurationRequest data) throws Exception {
return configClient.configure(data);
}
}
diff --git a/base/common/src/com/netscape/certsrv/system/SystemConfigResource.java b/base/common/src/com/netscape/certsrv/system/SystemConfigResource.java
index 0cebb6074..9c570eb2b 100644
--- a/base/common/src/com/netscape/certsrv/system/SystemConfigResource.java
+++ b/base/common/src/com/netscape/certsrv/system/SystemConfigResource.java
@@ -29,5 +29,5 @@ public interface SystemConfigResource {
@POST
@Path("configure")
- public ConfigurationResponse configure(ConfigurationRequest data);
+ public ConfigurationResponse configure(ConfigurationRequest data) throws Exception;
}