SE_BAD_FIELD, MIGHT_IGNORE , STATIC_INNER_CLASS

8 files changed, 11 insertions, 7 deletions

diff --git a/base/common/test/com/netscape/certsrv/authentication/AuthTokenTest.java b/base/common/test/com/netscape/certsrv/authentication/AuthTokenTest.java
index 370973f0a..1a5d999f6 100644
--- a/base/common/test/com/netscape/certsrv/authentication/AuthTokenTest.java
+++ b/base/common/test/com/netscape/certsrv/authentication/AuthTokenTest.java
@@ -255,7 +255,7 @@ public class AuthTokenTest extends CMSBaseTestCase {
      * getting a value out. It assumes BtoA is always called first, stores
      * the value passed in, and then returns that value for BtoA.
      */
-    class CMSMemoryStub extends CMSEngineDefaultStub {
+    static class CMSMemoryStub extends CMSEngineDefaultStub {
         boolean bToACalled = false;
         byte[] bToACalledWith = null;
 
diff --git a/base/common/test/com/netscape/cmscore/dbs/CertRecordListTest.java b/base/common/test/com/netscape/cmscore/dbs/CertRecordListTest.java
index d3177f62c..d9c24106c 100644
--- a/base/common/test/com/netscape/cmscore/dbs/CertRecordListTest.java
+++ b/base/common/test/com/netscape/cmscore/dbs/CertRecordListTest.java
@@ -80,7 +80,7 @@ public class CertRecordListTest extends CMSBaseTestCase {
         }
     }
 
-    public class ElementProcessorStub implements IElementProcessor {
+    public static class ElementProcessorStub implements IElementProcessor {
         public void process(Object o) throws EBaseException {
         }
     }
diff --git a/base/common/test/com/netscape/cmscore/dbs/DBRegistryTest.java b/base/common/test/com/netscape/cmscore/dbs/DBRegistryTest.java
index c74f66ba1..4a52bbcef 100644
--- a/base/common/test/com/netscape/cmscore/dbs/DBRegistryTest.java
+++ b/base/common/test/com/netscape/cmscore/dbs/DBRegistryTest.java
@@ -118,7 +118,7 @@ public class DBRegistryTest extends CMSBaseTestCase {
         }
     }
 
-    class DBDynAttrMapperStub extends DBDynAttrMapperDefaultStub {
+    static class DBDynAttrMapperStub extends DBDynAttrMapperDefaultStub {
         boolean mapObjectCalled = false;
         Object mapObjectCalledWithObject = null;
         boolean mapLDAPAttrsCalled = false;
diff --git a/base/common/test/com/netscape/cmscore/request/ExtAttrDynMapperTest.java b/base/common/test/com/netscape/cmscore/request/ExtAttrDynMapperTest.java
index a0ad0a8a3..35f999de7 100644
--- a/base/common/test/com/netscape/cmscore/request/ExtAttrDynMapperTest.java
+++ b/base/common/test/com/netscape/cmscore/request/ExtAttrDynMapperTest.java
@@ -259,7 +259,7 @@ public class ExtAttrDynMapperTest extends CMSBaseTestCase {
 
     }
 
-    class RequestRecordStub extends RequestRecordDefaultStub {
+    static class RequestRecordStub extends RequestRecordDefaultStub {
         private static final long serialVersionUID = 4106967075497999274L;
         Hashtable<String, Object> extAttrData = new Hashtable<String, Object>();
         int setCallCounter = 0;
diff --git a/base/common/test/com/netscape/cmscore/request/RequestDefaultStub.java b/base/common/test/com/netscape/cmscore/request/RequestDefaultStub.java
index fd53c2ea9..7a6bde408 100644
--- a/base/common/test/com/netscape/cmscore/request/RequestDefaultStub.java
+++ b/base/common/test/com/netscape/cmscore/request/RequestDefaultStub.java
@@ -23,6 +23,8 @@ import com.netscape.certsrv.request.RequestStatus;
  * Default testing stub for the IRequest interface.
  */
 public class RequestDefaultStub implements IRequest {
+    private static final long serialVersionUID = -8466522941927034614L;
+
     public RequestId getRequestId() {
         return null;
     }
diff --git a/base/common/test/com/netscape/cmscore/request/RequestQueueTest.java b/base/common/test/com/netscape/cmscore/request/RequestQueueTest.java
index a66326d03..6a0527572 100644
--- a/base/common/test/com/netscape/cmscore/request/RequestQueueTest.java
+++ b/base/common/test/com/netscape/cmscore/request/RequestQueueTest.java
@@ -40,7 +40,9 @@ public class RequestQueueTest extends CMSBaseTestCase {
         assertTrue(request.getExtDataKeysCalled);
     }
 
-    class RequestStub extends RequestDefaultStub {
+    static class RequestStub extends RequestDefaultStub {
+        private static final long serialVersionUID = -9058189963961484835L;
+
         String[] keys = new String[] { "key1", "key2" };
         boolean getExtDataKeysCalled = false;
 
diff --git a/base/common/test/com/netscape/cmscore/request/RequestRecordTest.java b/base/common/test/com/netscape/cmscore/request/RequestRecordTest.java
index 0ebf3beab..025684853 100644
--- a/base/common/test/com/netscape/cmscore/request/RequestRecordTest.java
+++ b/base/common/test/com/netscape/cmscore/request/RequestRecordTest.java
@@ -138,7 +138,7 @@ public class RequestRecordTest extends CMSBaseTestCase {
         }
     }
 
-    class DBRegistryStub extends DBRegistryDefaultStub {
+    static class DBRegistryStub extends DBRegistryDefaultStub {
         boolean registerCalledWithExtAttr = false;
         IDBAttrMapper extAttrMapper = null;
 
diff --git a/base/common/test/com/netscape/cmscore/request/RequestTest.java b/base/common/test/com/netscape/cmscore/request/RequestTest.java
index 1de96a203..b3a8c6ee5 100644
--- a/base/common/test/com/netscape/cmscore/request/RequestTest.java
+++ b/base/common/test/com/netscape/cmscore/request/RequestTest.java
@@ -667,7 +667,7 @@ public class RequestTest extends CMSBaseTestCase {
 
     }
 
-    class RevokedCertImplStub extends RevokedCertImpl {
+    static class RevokedCertImplStub extends RevokedCertImpl {
         /**
          *
          */