Fixes for Coverity Defects of Category : FB.DM_BOOLEAN_CTOR

8 files changed, 27 insertions, 27 deletions

diff --git a/base/common/src/com/netscape/cmscore/security/CASigningCert.java b/base/common/src/com/netscape/cmscore/security/CASigningCert.java
index 335bd9f37..8d35acf1b 100644
--- a/base/common/src/com/netscape/cmscore/security/CASigningCert.java
+++ b/base/common/src/com/netscape/cmscore/security/CASigningCert.java
@@ -153,10 +153,10 @@ public class CASigningCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
-        extension.set(KeyUsageExtension.NON_REPUDIATION, new Boolean(true));
-        extension.set(KeyUsageExtension.KEY_CERTSIGN, new Boolean(true));
-        extension.set(KeyUsageExtension.CRL_SIGN, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE,Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.NON_REPUDIATION, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.KEY_CERTSIGN, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.CRL_SIGN, Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/KRATransportCert.java b/base/common/src/com/netscape/cmscore/security/KRATransportCert.java
index 7e2e2f90d..58c269796 100644
--- a/base/common/src/com/netscape/cmscore/security/KRATransportCert.java
+++ b/base/common/src/com/netscape/cmscore/security/KRATransportCert.java
@@ -95,7 +95,7 @@ public class KRATransportCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, new Boolean(true));
+        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT,Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java b/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java
index ccbb004ce..7a980c621 100644
--- a/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java
+++ b/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java
@@ -909,49 +909,49 @@ public class KeyCertUtil {
         String sslClient = properties.getSSLClientBit();
 
         if ((sslClient != null) && (sslClient.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.SSL_CLIENT, new Boolean(true));
+            ns.set(NSCertTypeExtension.SSL_CLIENT, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String sslServer = properties.getSSLServerBit();
 
         if ((sslServer != null) && (sslServer.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.SSL_SERVER, new Boolean(true));
+            ns.set(NSCertTypeExtension.SSL_SERVER, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String sslMail = properties.getSSLMailBit();
 
         if ((sslMail != null) && (sslMail.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.EMAIL, new Boolean(true));
+            ns.set(NSCertTypeExtension.EMAIL, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String sslCA = properties.getSSLCABit();
 
         if ((sslCA != null) && (sslCA.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.SSL_CA, new Boolean(true));
+            ns.set(NSCertTypeExtension.SSL_CA, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String objectSigning = properties.getObjectSigningBit();
 
         if ((objectSigning != null) && (objectSigning.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.OBJECT_SIGNING, new Boolean(true));
+            ns.set(NSCertTypeExtension.OBJECT_SIGNING, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String mailCA = properties.getMailCABit();
 
         if ((mailCA != null) && (mailCA.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.EMAIL_CA, new Boolean(true));
+            ns.set(NSCertTypeExtension.EMAIL_CA, Boolean.valueOf(true));
             anyExt = true;
         }
 
         String objectSigningCA = properties.getObjectSigningCABit();
 
         if ((objectSigningCA != null) && (objectSigningCA.equals(Constants.TRUE))) {
-            ns.set(NSCertTypeExtension.OBJECT_SIGNING_CA, new Boolean(true));
+            ns.set(NSCertTypeExtension.OBJECT_SIGNING_CA, Boolean.valueOf(true));
             anyExt = true;
         }
         if (anyExt)
diff --git a/base/common/src/com/netscape/cmscore/security/OCSPSigningCert.java b/base/common/src/com/netscape/cmscore/security/OCSPSigningCert.java
index 16ca08b80..07ae9ee2f 100644
--- a/base/common/src/com/netscape/cmscore/security/OCSPSigningCert.java
+++ b/base/common/src/com/netscape/cmscore/security/OCSPSigningCert.java
@@ -131,10 +131,10 @@ public class OCSPSigningCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
-        extension.set(KeyUsageExtension.NON_REPUDIATION, new Boolean(true));
-        extension.set(KeyUsageExtension.KEY_CERTSIGN, new Boolean(true));
-        extension.set(KeyUsageExtension.CRL_SIGN, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.NON_REPUDIATION, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.KEY_CERTSIGN, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.CRL_SIGN, Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/RASigningCert.java b/base/common/src/com/netscape/cmscore/security/RASigningCert.java
index cf1de4203..51e05b5e9 100644
--- a/base/common/src/com/netscape/cmscore/security/RASigningCert.java
+++ b/base/common/src/com/netscape/cmscore/security/RASigningCert.java
@@ -101,7 +101,7 @@ public class RASigningCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/SSLCert.java b/base/common/src/com/netscape/cmscore/security/SSLCert.java
index 9dbec8abb..99b920c98 100644
--- a/base/common/src/com/netscape/cmscore/security/SSLCert.java
+++ b/base/common/src/com/netscape/cmscore/security/SSLCert.java
@@ -110,10 +110,10 @@ public class SSLCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
-        extension.set(KeyUsageExtension.NON_REPUDIATION, new Boolean(true));
-        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, new Boolean(true));
-        extension.set(KeyUsageExtension.DATA_ENCIPHERMENT, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.NON_REPUDIATION, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.DATA_ENCIPHERMENT, Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/SSLSelfSignedCert.java b/base/common/src/com/netscape/cmscore/security/SSLSelfSignedCert.java
index 328f6a86c..8cee1d155 100644
--- a/base/common/src/com/netscape/cmscore/security/SSLSelfSignedCert.java
+++ b/base/common/src/com/netscape/cmscore/security/SSLSelfSignedCert.java
@@ -105,9 +105,9 @@ public class SSLSelfSignedCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
-        //extension.set(KeyUsageExtension.NON_REPUDIATION, new Boolean(true));
-        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, Boolean.valueOf(true));
+        //extension.set(KeyUsageExtension.NON_REPUDIATION, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, Boolean.valueOf(true));
         return extension;
     }
 }
diff --git a/base/common/src/com/netscape/cmscore/security/SubsystemCert.java b/base/common/src/com/netscape/cmscore/security/SubsystemCert.java
index d0ce74490..5ad3e11f2 100644
--- a/base/common/src/com/netscape/cmscore/security/SubsystemCert.java
+++ b/base/common/src/com/netscape/cmscore/security/SubsystemCert.java
@@ -73,9 +73,9 @@ public class SubsystemCert extends CertificateInfo {
     protected KeyUsageExtension getKeyUsageExtension() throws IOException {
         KeyUsageExtension extension = new KeyUsageExtension();
 
-        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, new Boolean(true));
-        extension.set(KeyUsageExtension.NON_REPUDIATION, new Boolean(true));
-        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, new Boolean(true));
+        extension.set(KeyUsageExtension.DIGITAL_SIGNATURE, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.NON_REPUDIATION, Boolean.valueOf(true));
+        extension.set(KeyUsageExtension.KEY_ENCIPHERMENT, Boolean.valueOf(true));
         return extension;
     }
 }