diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-18 16:12:17 -0400 |
---|---|---|
committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:08:51 -0400 |
commit | 9db76ed1d1f8969e93aaff320e49662f53688e2e (patch) | |
tree | 2e7af87ca0f72cdf4eb982764757d2884b21ce7b /base/common/src/com/netscape/cmscore/security/PWsdrCache.java | |
parent | a4db0f39e257950a5c89203452c1184c7080e5bd (diff) | |
download | pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.gz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.xz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.zip |
Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION
Diffstat (limited to 'base/common/src/com/netscape/cmscore/security/PWsdrCache.java')
-rw-r--r-- | base/common/src/com/netscape/cmscore/security/PWsdrCache.java | 24 |
1 files changed, 8 insertions, 16 deletions
diff --git a/base/common/src/com/netscape/cmscore/security/PWsdrCache.java b/base/common/src/com/netscape/cmscore/security/PWsdrCache.java index 2e0dfd550..e4e8a432b 100644 --- a/base/common/src/com/netscape/cmscore/security/PWsdrCache.java +++ b/base/common/src/com/netscape/cmscore/security/PWsdrCache.java @@ -231,11 +231,12 @@ public class PWsdrCache { */ public void addEntry(String tag, String pwd, Hashtable<String, String> tagPwds) throws EBaseException { - String stringToAdd = null; + StringBuffer stringToAdd = new StringBuffer(); + String bufs = null; if (tagPwds == null) { - stringToAdd = tag + ":" + pwd + "\n"; + stringToAdd.append(tag + ":" + pwd + System.getProperty("line.separator")); } else { Enumeration<String> enum1 = tagPwds.keys(); @@ -244,11 +245,7 @@ public class PWsdrCache { pwd = tagPwds.get(tag); debug("password tag: " + tag + " stored in " + mPWcachedb); - if (stringToAdd == null) { - stringToAdd = tag + ":" + pwd + "\n"; - } else { - stringToAdd += tag + ":" + pwd + "\n"; - } + stringToAdd.append(tag + ":" + pwd + System.getProperty("line.separator")); } } @@ -269,7 +266,7 @@ public class PWsdrCache { bufs = hashtable2String(ht); } else { debug("adding new tag: " + tag); - bufs = stringToAdd; + bufs = stringToAdd.toString(); } // write update to cache @@ -436,19 +433,14 @@ public class PWsdrCache { public String hashtable2String(Hashtable<String, String> ht) { Enumeration<String> enum1 = ht.keys(); - String returnString = null; + StringBuffer returnString = new StringBuffer(); while (enum1.hasMoreElements()) { String tag = enum1.nextElement(); String pwd = ht.get(tag); - - if (returnString == null) { - returnString = tag + ":" + pwd + "\n"; - } else { - returnString += tag + ":" + pwd + "\n"; - } + returnString.append(tag + ":" + pwd + System.getProperty("line.separator")); } - return returnString; + return returnString.toString(); } public Hashtable<String, String> string2Hashtable(String cache) { |