summaryrefslogtreecommitdiffstats
path: root/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java
diff options
context:
space:
mode:
authorAbhishek Koneru <akoneru@redhat.com>2012-06-15 10:28:40 -0400
committerEndi Sukma Dewata <edewata@redhat.com>2012-06-20 09:33:31 -0500
commitd5d0b91bc5597eec19520cee74569e9ddacc2090 (patch)
tree414a43625acd2e3f44c39cdd87912e5c562930e7 /base/common/src/com/netscape/cmscore/security/KeyCertUtil.java
parent4880d86856d183d4ba3fb0291519353ac238af5d (diff)
downloadpki-d5d0b91bc5597eec19520cee74569e9ddacc2090.tar.gz
pki-d5d0b91bc5597eec19520cee74569e9ddacc2090.tar.xz
pki-d5d0b91bc5597eec19520cee74569e9ddacc2090.zip
Fixes for Coverity Issues of type Null Returns - Part 3
Diffstat (limited to 'base/common/src/com/netscape/cmscore/security/KeyCertUtil.java')
-rw-r--r--base/common/src/com/netscape/cmscore/security/KeyCertUtil.java7
1 files changed, 5 insertions, 2 deletions
diff --git a/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java b/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java
index 844052e4b..80ad36c2d 100644
--- a/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java
+++ b/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java
@@ -1056,8 +1056,11 @@ public class KeyCertUtil {
String dn = "ou=certificateRepository,ou=ca," + baseDN;
BigInteger serialno = null;
LDAPEntry entry = conn.read(dn);
- String serialnoStr = (String) entry.getAttribute(
- "serialno").getStringValues().nextElement();
+ LDAPAttribute serialNo = entry.getAttribute("serialno");
+ if (serialNo == null) {
+ throw new LDAPException("No value for attribute serial number in LDAP entry " + entry.getDN());
+ }
+ String serialnoStr = (String) serialNo.getStringValues().nextElement();
serialno = BigIntegerMapper.BigIntegerFromDB(serialnoStr);
LDAPAttribute attr = new LDAPAttribute("serialno");