diff options
| author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-18 16:12:17 -0400 |
|---|---|---|
| committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:08:51 -0400 |
| commit | 9db76ed1d1f8969e93aaff320e49662f53688e2e (patch) | |
| tree | 2e7af87ca0f72cdf4eb982764757d2884b21ce7b /base/common/src/com/netscape/cmscore/security/KeyCertUtil.java | |
| parent | a4db0f39e257950a5c89203452c1184c7080e5bd (diff) | |
| download | pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.gz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.xz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.zip | |
Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION
Diffstat (limited to 'base/common/src/com/netscape/cmscore/security/KeyCertUtil.java')
| -rw-r--r-- | base/common/src/com/netscape/cmscore/security/KeyCertUtil.java | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java b/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java index 7a980c621..844052e4b 100644 --- a/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java +++ b/base/common/src/com/netscape/cmscore/security/KeyCertUtil.java @@ -151,7 +151,8 @@ public class KeyCertUtil { public static String getTokenNames(CryptoManager manager) throws TokenException { - String tokenList = ""; + StringBuffer tokenList = new StringBuffer(); + @SuppressWarnings("unchecked") Enumeration<CryptoToken> tokens = manager.getExternalTokens(); int num = 0; @@ -159,16 +160,15 @@ public class KeyCertUtil { while (tokens.hasMoreElements()) { CryptoToken c = tokens.nextElement(); - if (num++ == 0) - tokenList = tokenList + c.getName(); - else - tokenList = tokenList + "," + c.getName(); + if (num++ != 0) + tokenList.append(","); + tokenList.append(c.getName()); } - if (tokenList.equals("")) + if (tokenList.length() == 0) return Constants.PR_INTERNAL_TOKEN; else - return (tokenList + "," + Constants.PR_INTERNAL_TOKEN); + return (tokenList.toString() + "," + Constants.PR_INTERNAL_TOKEN); } public static String base64Encode(byte[] bytes) throws IOException { |