diff options
| author | Abhishek Koneru <akoneru@redhat.com> | 2012-06-11 16:21:26 -0400 |
|---|---|---|
| committer | Endi Sukma Dewata <edewata@redhat.com> | 2012-06-15 17:12:15 -0500 |
| commit | 10326ad4fe1b3db620f43feb3f47c4fd008f3f33 (patch) | |
| tree | 4d4a0f719bbbea6d6db53ef3fab5f3717411cfb9 /base/common/src/com/netscape/cmscore/realm | |
| parent | c53ca291e21761f1de5417ef596afba395a7f5d1 (diff) | |
| download | pki-10326ad4fe1b3db620f43feb3f47c4fd008f3f33.tar.gz pki-10326ad4fe1b3db620f43feb3f47c4fd008f3f33.tar.xz pki-10326ad4fe1b3db620f43feb3f47c4fd008f3f33.zip | |
Fixes for Coverity issues of type Stringbuffer, NO_EQUALS_METHOD , REVERSE_INULL,Wrong_Map_Iterators
Diffstat (limited to 'base/common/src/com/netscape/cmscore/realm')
| -rw-r--r-- | base/common/src/com/netscape/cmscore/realm/ACL.java | 6 | ||||
| -rw-r--r-- | base/common/src/com/netscape/cmscore/realm/PKIJNDIRealm.java | 3 |
2 files changed, 3 insertions, 6 deletions
diff --git a/base/common/src/com/netscape/cmscore/realm/ACL.java b/base/common/src/com/netscape/cmscore/realm/ACL.java index 6c06c92c1..13fcdac44 100644 --- a/base/common/src/com/netscape/cmscore/realm/ACL.java +++ b/base/common/src/com/netscape/cmscore/realm/ACL.java @@ -150,15 +150,15 @@ public class ACL { * <resource name>[<ACLEntry1>,<ACLEntry 2>,...<ACLEntry N>] */ public String toString() { - String entries = ""; + StringBuilder entries = new StringBuilder(); Enumeration<ACLEntry> e = entries(); for (; e.hasMoreElements();) { ACLEntry entry = e.nextElement(); - entries += entry.toString(); + entries.append(entry); if (e.hasMoreElements()) - entries += ","; + entries.append(","); } return getName() + "[" + entries + "]"; } diff --git a/base/common/src/com/netscape/cmscore/realm/PKIJNDIRealm.java b/base/common/src/com/netscape/cmscore/realm/PKIJNDIRealm.java index abd27fddf..0576bcf58 100644 --- a/base/common/src/com/netscape/cmscore/realm/PKIJNDIRealm.java +++ b/base/common/src/com/netscape/cmscore/realm/PKIJNDIRealm.java @@ -869,9 +869,6 @@ public class PKIJNDIRealm extends JNDIRealm { private synchronized void loadAuthzProperties(Context context) { if (authzProperties == null && context != null) { - ClassLoader loader = this.getClass().getClassLoader(); - if (loader == null) - loader = ClassLoader.getSystemClassLoader(); InputStream inputStream = context.getServletContext().getResourceAsStream(PROP_AUTH_FILE_PATH); |