diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-18 16:12:17 -0400 |
---|---|---|
committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:08:51 -0400 |
commit | 9db76ed1d1f8969e93aaff320e49662f53688e2e (patch) | |
tree | 2e7af87ca0f72cdf4eb982764757d2884b21ce7b /base/common/src/com/netscape/cmscore/ldap/LdapRule.java | |
parent | a4db0f39e257950a5c89203452c1184c7080e5bd (diff) | |
download | pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.gz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.xz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.zip |
Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION
Diffstat (limited to 'base/common/src/com/netscape/cmscore/ldap/LdapRule.java')
-rw-r--r-- | base/common/src/com/netscape/cmscore/ldap/LdapRule.java | 31 |
1 files changed, 18 insertions, 13 deletions
diff --git a/base/common/src/com/netscape/cmscore/ldap/LdapRule.java b/base/common/src/com/netscape/cmscore/ldap/LdapRule.java index f5fdcc502..eaf5e763a 100644 --- a/base/common/src/com/netscape/cmscore/ldap/LdapRule.java +++ b/base/common/src/com/netscape/cmscore/ldap/LdapRule.java @@ -66,28 +66,28 @@ public class LdapRule implements ILdapRule, IExtendedPluginInfo { mProcessor = processor; Enumeration<String> mappers = mProcessor.getMapperInsts().keys(); Enumeration<String> publishers = mProcessor.getPublisherInsts().keys(); - - String map = NOMAPPER; + StringBuffer map=new StringBuffer(); + map.append(NOMAPPER); for (; mappers.hasMoreElements();) { String name = mappers.nextElement(); - map = map + "," + name; + map.append(",").append(name); } - String publish = ""; + StringBuffer publish = new StringBuffer(); for (; publishers.hasMoreElements();) { String name = publishers.nextElement(); - publish = publish + "," + name; + publish.append(",").append(name); } epi_params = new String[] { "type;choice(cacert,crl, certs);The publishing object type", "mapper;choice(" - + map + ");Use the mapper to find the ldap dn \nto publish the certificate or crl", + + map.toString() + ");Use the mapper to find the ldap dn \nto publish the certificate or crl", "publisher;choice(" - + publish + ");Use the publisher to publish the certificate or crl a directory etc", + + publish.toString() + ");Use the publisher to publish the certificate or crl a directory etc", "enable;boolean;Enable this publishing rule", "predicate;string;Filter describing when this publishing rule shoule be used" }; @@ -171,22 +171,27 @@ public class LdapRule implements ILdapRule, IExtendedPluginInfo { public Vector<String> getInstanceParams() { //if (mProcessor == null) System.out.println("xxxxnull"); //dont know why the processor was null in getExtendedPluginInfo() - Enumeration<String> mappers = mProcessor.getMapperInsts().keys(); + + /* Commented block contains variables which are used only in the below commented block. + * + * Enumeration<String> mappers = mProcessor.getMapperInsts().keys(); Enumeration<String> publishers = mProcessor.getPublisherInsts().keys(); - String map = NOMAPPER; + StringBuffer map=new StringBuffer(); + map.append(NOMAPPER); for (; mappers.hasMoreElements();) { String name = mappers.nextElement(); - map = map + "," + name; + map.append(",").append(name); } - String publish = ""; + StringBuffer publish=new StringBuffer(); + for (; publishers.hasMoreElements();) { String name = publishers.nextElement(); - publish = publish + "," + name; - } + publish.append(",").append(name); + }*/ /* mExtendedPluginInfo = new NameValuePairs(); |