diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-06-21 09:44:15 -0400 |
---|---|---|
committer | Ade Lee <alee@redhat.com> | 2012-06-29 01:29:03 -0400 |
commit | eb4b46f25ca8dec8ac79c26cfb02e8918000c88e (patch) | |
tree | 22223edf9099ac1a3e0c3914d383c373a92950b0 /base/common/src/com/netscape/cmscore/dbs | |
parent | 1eba8264adbe42115caac4db655d450a99791ceb (diff) | |
download | pki-eb4b46f25ca8dec8ac79c26cfb02e8918000c88e.tar.gz pki-eb4b46f25ca8dec8ac79c26cfb02e8918000c88e.tar.xz pki-eb4b46f25ca8dec8ac79c26cfb02e8918000c88e.zip |
Fixes for Forward Null Cases in Coverity for DogTag10
Addressed review coments.
Diffstat (limited to 'base/common/src/com/netscape/cmscore/dbs')
-rw-r--r-- | base/common/src/com/netscape/cmscore/dbs/BigIntegerMapper.java | 3 | ||||
-rw-r--r-- | base/common/src/com/netscape/cmscore/dbs/Repository.java | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/base/common/src/com/netscape/cmscore/dbs/BigIntegerMapper.java b/base/common/src/com/netscape/cmscore/dbs/BigIntegerMapper.java index 9af436295..d59f081db 100644 --- a/base/common/src/com/netscape/cmscore/dbs/BigIntegerMapper.java +++ b/base/common/src/com/netscape/cmscore/dbs/BigIntegerMapper.java @@ -101,6 +101,9 @@ public class BigIntegerMapper implements IDBAttrMapper { } public static String BigIntegerToDB(BigInteger i) { + if (i == null) { + return null; + } int len = i.toString().length(); String ret = null; diff --git a/base/common/src/com/netscape/cmscore/dbs/Repository.java b/base/common/src/com/netscape/cmscore/dbs/Repository.java index 4a438c07c..57ac5004d 100644 --- a/base/common/src/com/netscape/cmscore/dbs/Repository.java +++ b/base/common/src/com/netscape/cmscore/dbs/Repository.java @@ -393,14 +393,13 @@ public abstract class Repository implements IRepository { CMS.debug("Reached the end of the range. Attempting to move to next range"); mMinSerialNo = mNextMinSerialNo; mMaxSerialNo = mNextMaxSerialNo; - mLastSerialNo = mMinSerialNo; mNextMinSerialNo = null; mNextMaxSerialNo = null; if ((mMaxSerialNo == null) || (mMinSerialNo == null)) { throw new EDBException(CMS.getUserMessage("CMS_DBS_LIMIT_REACHED", mLastSerialNo.toString())); } - + mLastSerialNo = mMinSerialNo; // persist the changes mDB.setMinSerialConfig(mRepo, mMinSerialNo.toString()); mDB.setMaxSerialConfig(mRepo, mMaxSerialNo.toString()); |