diff options
| author | Abhishek Koneru <akoneru@redhat.com> | 2012-06-27 14:27:55 -0400 |
|---|---|---|
| committer | Endi Sukma Dewata <edewata@redhat.com> | 2012-07-02 12:43:57 -0500 |
| commit | 10502e34a10fb3b672aef1161cc271003c7806ba (patch) | |
| tree | 4c3c5e8fc8c99759953b52518f78e8ba3100aa17 /base/common/src/com/netscape/cmscore/cert | |
| parent | d2b06ee1f9fcc42be83f04f64559cfa6317bda67 (diff) | |
| download | pki-10502e34a10fb3b672aef1161cc271003c7806ba.tar.gz pki-10502e34a10fb3b672aef1161cc271003c7806ba.tar.xz pki-10502e34a10fb3b672aef1161cc271003c7806ba.zip | |
Fixes for Guarded_By_Violation issues shown in Coverity
Diffstat (limited to 'base/common/src/com/netscape/cmscore/cert')
3 files changed, 6 insertions, 4 deletions
diff --git a/base/common/src/com/netscape/cmscore/cert/CrossCertPairSubsystem.java b/base/common/src/com/netscape/cmscore/cert/CrossCertPairSubsystem.java index dd7918bd5..4db850d2e 100644 --- a/base/common/src/com/netscape/cmscore/cert/CrossCertPairSubsystem.java +++ b/base/common/src/com/netscape/cmscore/cert/CrossCertPairSubsystem.java @@ -101,8 +101,10 @@ public class CrossCertPairSubsystem implements ICrossCertPairSubsystem { try { mConfig = config; mLogger = CMS.getLogger(); - mCa = (ICertificateAuthority) CMS.getSubsystem("ca"); - mPublisherProcessor = mCa.getPublisherProcessor(); + synchronized (this) { + mCa = (ICertificateAuthority) CMS.getSubsystem("ca"); + mPublisherProcessor = mCa.getPublisherProcessor(); + } // initialize LDAP connection factory IConfigStore ldapConfig = mConfig.getSubStore(PROP_LDAP); diff --git a/base/common/src/com/netscape/cmscore/cert/OidLoaderSubsystem.java b/base/common/src/com/netscape/cmscore/cert/OidLoaderSubsystem.java index 0feebb7ec..95bbd98e7 100644 --- a/base/common/src/com/netscape/cmscore/cert/OidLoaderSubsystem.java +++ b/base/common/src/com/netscape/cmscore/cert/OidLoaderSubsystem.java @@ -182,7 +182,7 @@ public class OidLoaderSubsystem implements ISubsystem { * * @return configuration store of this subsystem */ - public IConfigStore getConfigStore() { + public synchronized IConfigStore getConfigStore() { return mConfig; } diff --git a/base/common/src/com/netscape/cmscore/cert/X500NameSubsystem.java b/base/common/src/com/netscape/cmscore/cert/X500NameSubsystem.java index 96dc64e57..7accf2b4f 100644 --- a/base/common/src/com/netscape/cmscore/cert/X500NameSubsystem.java +++ b/base/common/src/com/netscape/cmscore/cert/X500NameSubsystem.java @@ -277,7 +277,7 @@ public class X500NameSubsystem implements ISubsystem { protected ILogger mLogger = null; - protected void log(int level, String msg) { + protected synchronized void log(int level, String msg) { mLogger.log(ILogger.EV_SYSTEM, ILogger.S_ADMIN, level, msg); } |