diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-06-20 13:56:57 -0400 |
---|---|---|
committer | Endi Sukma Dewata <edewata@redhat.com> | 2012-06-25 13:38:26 -0500 |
commit | 8a8436f73d4c4edd10b43313b724f32ccb7b957e (patch) | |
tree | 657c8f9accd34d286acf0569f768c72684a12b75 /base/common/src/com/netscape/cmscore/cert | |
parent | de3aaef15e9b1f192344019f52d6c80860055b5e (diff) | |
download | pki-8a8436f73d4c4edd10b43313b724f32ccb7b957e.tar.gz pki-8a8436f73d4c4edd10b43313b724f32ccb7b957e.tar.xz pki-8a8436f73d4c4edd10b43313b724f32ccb7b957e.zip |
Fixes for Coverity issues of type Resource Leaks - Remaining
Diffstat (limited to 'base/common/src/com/netscape/cmscore/cert')
-rw-r--r-- | base/common/src/com/netscape/cmscore/cert/CertUtils.java | 35 |
1 files changed, 23 insertions, 12 deletions
diff --git a/base/common/src/com/netscape/cmscore/cert/CertUtils.java b/base/common/src/com/netscape/cmscore/cert/CertUtils.java index d443781ae..ee1e1568c 100644 --- a/base/common/src/com/netscape/cmscore/cert/CertUtils.java +++ b/base/common/src/com/netscape/cmscore/cert/CertUtils.java @@ -525,23 +525,34 @@ public class CertUtils { public static byte[] readFromFile(String fileName) throws IOException { - FileInputStream fin = new FileInputStream(fileName); - int available = fin.available(); - byte[] ba = new byte[available]; - int nRead = fin.read(ba); - - if (nRead != available) - throw new IOException("Error reading data from file: " + fileName); - fin.close(); - return ba; + FileInputStream fin = null; + try { + fin = new FileInputStream(fileName); + int available = fin.available(); + byte[] ba = new byte[available]; + int nRead = fin.read(ba); + + if (nRead != available) + throw new IOException("Error reading data from file: " + fileName); + + return ba; + } finally { + if (fin != null) + fin.close(); + } } public static void storeInFile(String fileName, byte[] ba) throws IOException { - FileOutputStream fout = new FileOutputStream(fileName); + FileOutputStream fout = null; + try { + fout = new FileOutputStream(fileName); - fout.write(ba); - fout.close(); + fout.write(ba); + } finally { + if (fout != null) + fout.close(); + } } public static String toMIME64(X509CertImpl cert) { |