diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-18 16:12:17 -0400 |
---|---|---|
committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:08:51 -0400 |
commit | 9db76ed1d1f8969e93aaff320e49662f53688e2e (patch) | |
tree | 2e7af87ca0f72cdf4eb982764757d2884b21ce7b /base/common/src/com/netscape/cmscore/cert | |
parent | a4db0f39e257950a5c89203452c1184c7080e5bd (diff) | |
download | pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.gz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.tar.xz pki-9db76ed1d1f8969e93aaff320e49662f53688e2e.zip |
Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION
Diffstat (limited to 'base/common/src/com/netscape/cmscore/cert')
-rw-r--r-- | base/common/src/com/netscape/cmscore/cert/CertUtils.java | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/base/common/src/com/netscape/cmscore/cert/CertUtils.java b/base/common/src/com/netscape/cmscore/cert/CertUtils.java index 009e9b0d9..d443781ae 100644 --- a/base/common/src/com/netscape/cmscore/cert/CertUtils.java +++ b/base/common/src/com/netscape/cmscore/cert/CertUtils.java @@ -612,7 +612,7 @@ public class CertUtils { } public static String normalizeCertStr(String s) { - String val = ""; + StringBuffer val = new StringBuffer(); for (int i = 0; i < s.length(); i++) { if (s.charAt(i) == '\n') { @@ -624,9 +624,9 @@ public class CertUtils { } else if (s.charAt(i) == ' ') { continue; } - val += s.charAt(i); + val.append(s.charAt(i)); } - return val; + return val.toString(); } public static String stripCRLBrackets(String s) { @@ -747,17 +747,17 @@ public class CertUtils { throws NoSuchAlgorithmException/*, CertificateEncodingException*/{ // byte certDer[] = cert.getEncoded(); String[] hashes = new String[] { "MD2", "MD5", "SHA1", "SHA256", "SHA512" }; - String certFingerprints = ""; + StringBuffer certFingerprints = new StringBuffer(); PrettyPrintFormat pp = new PrettyPrintFormat(":"); for (int i = 0; i < hashes.length; i++) { MessageDigest md = MessageDigest.getInstance(hashes[i]); md.update(certDer); - certFingerprints += hashes[i] + ":\n" + - pp.toHexString(md.digest(), 8, 16); + certFingerprints.append(hashes[i] + ":\n" + + pp.toHexString(md.digest(), 8, 16)); } - return certFingerprints; + return certFingerprints.toString(); } /** |