diff options
| author | Abhishek Koneru <akoneru@redhat.com> | 2012-06-21 09:44:15 -0400 |
|---|---|---|
| committer | Ade Lee <alee@redhat.com> | 2012-06-29 01:29:03 -0400 |
| commit | eb4b46f25ca8dec8ac79c26cfb02e8918000c88e (patch) | |
| tree | 22223edf9099ac1a3e0c3914d383c373a92950b0 /base/common/src/com/netscape/cmscore/apps/CMSEngine.java | |
| parent | 1eba8264adbe42115caac4db655d450a99791ceb (diff) | |
| download | pki-eb4b46f25ca8dec8ac79c26cfb02e8918000c88e.tar.gz pki-eb4b46f25ca8dec8ac79c26cfb02e8918000c88e.tar.xz pki-eb4b46f25ca8dec8ac79c26cfb02e8918000c88e.zip | |
Fixes for Forward Null Cases in Coverity for DogTag10
Addressed review coments.
Diffstat (limited to 'base/common/src/com/netscape/cmscore/apps/CMSEngine.java')
| -rw-r--r-- | base/common/src/com/netscape/cmscore/apps/CMSEngine.java | 49 |
1 files changed, 24 insertions, 25 deletions
diff --git a/base/common/src/com/netscape/cmscore/apps/CMSEngine.java b/base/common/src/com/netscape/cmscore/apps/CMSEngine.java index 855073916..cbdfee8fc 100644 --- a/base/common/src/com/netscape/cmscore/apps/CMSEngine.java +++ b/base/common/src/com/netscape/cmscore/apps/CMSEngine.java @@ -308,13 +308,12 @@ public class CMSEngine implements ICMSEngine { CMS.debug("CMSEngine: getPasswordStore(): password store not initialized before."); String pwdClass = mConfig.getString("passwordClass"); - if (pwdClass != null) { - try { - mPasswordStore = (IPasswordStore) Class.forName(pwdClass).newInstance(); - } catch (Exception e) { - CMS.debug("CMSEngine: getPasswordStore(): password store initialization failure:" - + e.toString()); - } + try { + mPasswordStore = (IPasswordStore) Class.forName(pwdClass).newInstance(); + } catch (Exception e) { + CMS.debug("CMSEngine: getPasswordStore(): password store initialization failure:" + + e.toString()); + throw e; } } else { CMS.debug("CMSEngine: getPasswordStore(): password store initialized before."); @@ -1877,32 +1876,32 @@ public class CMSEngine implements ICMSEngine { checkRevReq.setExtData(IRequest.ISSUED_CERTS, agentCerts); queue.processRequest(checkRevReq); - } catch (EBaseException e) { - log(ILogger.LL_FAILURE, CMS.getLogMessage("CMSCORE_AUTH_AGENT_PROCESS_CHECKING")); - } - RequestStatus status = checkRevReq.getRequestStatus(); + RequestStatus status = checkRevReq.getRequestStatus(); - if (status == RequestStatus.COMPLETE) { - Enumeration<String> enum1 = checkRevReq.getExtDataKeys(); + if (status == RequestStatus.COMPLETE) { + Enumeration<String> enum1 = checkRevReq.getExtDataKeys(); - while (enum1.hasMoreElements()) { - String name = enum1.nextElement(); + while (enum1.hasMoreElements()) { + String name = enum1.nextElement(); - if (name.equals(IRequest.REVOKED_CERTS)) { - revoked = true; + if (name.equals(IRequest.REVOKED_CERTS)) { + revoked = true; + if (mVCList != null) + mVCList.update(cert, VerifiedCert.REVOKED); + } + } + if (revoked == false) { if (mVCList != null) - mVCList.update(cert, VerifiedCert.REVOKED); + mVCList.update(cert, VerifiedCert.NOT_REVOKED); } - } - if (revoked == false) { + + } else { if (mVCList != null) - mVCList.update(cert, VerifiedCert.NOT_REVOKED); + mVCList.update(cert, VerifiedCert.CHECKED); } - - } else { - if (mVCList != null) - mVCList.update(cert, VerifiedCert.CHECKED); + } catch (EBaseException e) { + log(ILogger.LL_FAILURE, CMS.getLogMessage("CMSCORE_AUTH_AGENT_PROCESS_CHECKING")); } } } |