diff options
| author | Abhishek Koneru <akoneru@redhat.com> | 2012-06-11 16:21:26 -0400 |
|---|---|---|
| committer | Endi Sukma Dewata <edewata@redhat.com> | 2012-06-15 17:12:15 -0500 |
| commit | 10326ad4fe1b3db620f43feb3f47c4fd008f3f33 (patch) | |
| tree | 4d4a0f719bbbea6d6db53ef3fab5f3717411cfb9 /base/common/src/com/netscape/certsrv | |
| parent | c53ca291e21761f1de5417ef596afba395a7f5d1 (diff) | |
| download | pki-10326ad4fe1b3db620f43feb3f47c4fd008f3f33.tar.gz pki-10326ad4fe1b3db620f43feb3f47c4fd008f3f33.tar.xz pki-10326ad4fe1b3db620f43feb3f47c4fd008f3f33.zip | |
Fixes for Coverity issues of type Stringbuffer, NO_EQUALS_METHOD , REVERSE_INULL,Wrong_Map_Iterators
Diffstat (limited to 'base/common/src/com/netscape/certsrv')
| -rw-r--r-- | base/common/src/com/netscape/certsrv/common/NameValuePairs.java | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/base/common/src/com/netscape/certsrv/common/NameValuePairs.java b/base/common/src/com/netscape/certsrv/common/NameValuePairs.java index 0f95ad2e3..30491cdd0 100644 --- a/base/common/src/com/netscape/certsrv/common/NameValuePairs.java +++ b/base/common/src/com/netscape/certsrv/common/NameValuePairs.java @@ -18,6 +18,7 @@ package com.netscape.certsrv.common; import java.util.LinkedHashMap; +import java.util.Map; import java.util.StringTokenizer; /** @@ -43,12 +44,11 @@ public class NameValuePairs extends LinkedHashMap<String, String> { * @return string representation */ public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); - for (String name : keySet()) { - String value = get(name); + for (Map.Entry<String, String> entry : entrySet()) { - buf.append(name + "=" + value); + buf.append(String.format("%s=%s", entry.getKey(), entry.getValue())); buf.append("\n"); } |