diff options
author | Ade Lee <alee@redhat.com> | 2016-04-19 14:52:40 -0400 |
---|---|---|
committer | Ade Lee <alee@redhat.com> | 2016-04-20 17:31:01 -0400 |
commit | b59d8305130e81d3e00240b5612a327c9dfc7d12 (patch) | |
tree | 0634fd72c54083da01fa8bf5173c027cb3a55fdb /base/common/src/com/netscape/certsrv/key/KeyGenerationRequest.java | |
parent | 3e4eb72ec8a295784e9283cccf637d4199d96626 (diff) | |
download | pki-b59d8305130e81d3e00240b5612a327c9dfc7d12.tar.gz pki-b59d8305130e81d3e00240b5612a327c9dfc7d12.tar.xz pki-b59d8305130e81d3e00240b5612a327c9dfc7d12.zip |
Realms - Address comments from review
Review comments addressed:
1. when archiving or generating keys, realm is checked
2. when no plugin is found for a realm, access is denied.
3. rename mFoo to foo for new variables.
4. add chaining of exceptions
5. remove attributes from KeyArchivalRequest etc. when realm is null
6. Add more detail to denial in BasicGroupAuthz
Part of Trac Ticket 2041
Diffstat (limited to 'base/common/src/com/netscape/certsrv/key/KeyGenerationRequest.java')
-rw-r--r-- | base/common/src/com/netscape/certsrv/key/KeyGenerationRequest.java | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/base/common/src/com/netscape/certsrv/key/KeyGenerationRequest.java b/base/common/src/com/netscape/certsrv/key/KeyGenerationRequest.java index 37fc1c2b2..50946bb9f 100644 --- a/base/common/src/com/netscape/certsrv/key/KeyGenerationRequest.java +++ b/base/common/src/com/netscape/certsrv/key/KeyGenerationRequest.java @@ -134,6 +134,10 @@ public class KeyGenerationRequest extends ResourceMessage{ * @param realm - authorization realm to set */ public void setRealm(String realm) { - attributes.put(REALM, realm); + if (realm != null) { + attributes.put(REALM, realm); + } else { + attributes.remove(REALM); + } } } |