Realms - Address comments from review

Review comments addressed:
1. when archiving or generating keys, realm is checked
2. when no plugin is found for a realm, access is denied.
3. rename mFoo to foo for new variables.
4. add chaining of exceptions
5. remove attributes from KeyArchivalRequest etc. when realm is null
6. Add more detail to denial in BasicGroupAuthz

Part of Trac Ticket 2041

1 files changed, 4 insertions, 15 deletions

diff --git a/base/common/src/com/netscape/certsrv/key/KeyClient.java b/base/common/src/com/netscape/certsrv/key/KeyClient.java
index 1c8a76bfe..cb35922f6 100644
--- a/base/common/src/com/netscape/certsrv/key/KeyClient.java
+++ b/base/common/src/com/netscape/certsrv/key/KeyClient.java
@@ -653,10 +653,7 @@ public class KeyClient extends Client {
         String req1 = Utils.base64encode(encryptedData);
         data.setWrappedPrivateData(req1);
         data.setTransWrappedSessionKey(Utils.base64encode(transWrappedSessionKey));
-
-        if (realm != null) {
-            data.setRealm(realm);
-        }
+        data.setRealm(realm);
 
         return submitRequest(data);
     }
@@ -708,10 +705,7 @@ public class KeyClient extends Client {
 
         String options = Utils.base64encode(pkiArchiveOptions);
         data.setPKIArchiveOptions(options);
-
-        if (realm != null) {
-            data.setRealm(realm);
-        }
+        data.setRealm(realm);
 
         return submitRequest(data);
     }
@@ -757,9 +751,7 @@ public class KeyClient extends Client {
         data.setUsages(usages);
         data.setTransWrappedSessionKey(transWrappedSessionKey);
 
-        if (realm != null) {
-            data.setRealm(realm);
-        }
+        data.setRealm(realm);
 
         return submitRequest(data);
     }
@@ -829,10 +821,7 @@ public class KeyClient extends Client {
         data.setKeySize(keySize);
         data.setUsages(usages);
         data.setTransWrappedSessionKey(Utils.base64encode(transWrappedSessionKey));
-
-        if (realm != null) {
-            data.setRealm(realm);
-        }
+        data.setRealm(realm);
 
         return submitRequest(data);
     }