diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-06-05 12:16:51 -0400 |
---|---|---|
committer | Endi Sukma Dewata <edewata@redhat.com> | 2012-06-05 14:46:08 -0500 |
commit | 4a012010233b0a5fd613c9d7734ee01be64e3834 (patch) | |
tree | 53affd70c3c2b5d0d909641f847b938e80e874c7 /base/ca | |
parent | c2128339ba046ceb7ab32954ae07dbb4b41d4e73 (diff) | |
download | pki-4a012010233b0a5fd613c9d7734ee01be64e3834.tar.gz pki-4a012010233b0a5fd613c9d7734ee01be64e3834.tar.xz pki-4a012010233b0a5fd613c9d7734ee01be64e3834.zip |
Fixes for NULL_RETURN cases review comments
Diffstat (limited to 'base/ca')
-rw-r--r-- | base/ca/src/com/netscape/ca/CRLIssuingPoint.java | 40 |
1 files changed, 21 insertions, 19 deletions
diff --git a/base/ca/src/com/netscape/ca/CRLIssuingPoint.java b/base/ca/src/com/netscape/ca/CRLIssuingPoint.java index 56dcc2457..5dd823737 100644 --- a/base/ca/src/com/netscape/ca/CRLIssuingPoint.java +++ b/base/ca/src/com/netscape/ca/CRLIssuingPoint.java @@ -1694,23 +1694,24 @@ public class CRLIssuingPoint implements ICRLIssuingPoint, Runnable { * <P> */ public void run() { - while (mEnable && ((mEnableCRLCache && mCacheUpdateInterval > 0) || - (mInitialized == CRL_IP_NOT_INITIALIZED) || - mDoLastAutoUpdate || (mEnableCRLUpdates && + try { + while (mEnable && ((mEnableCRLCache && mCacheUpdateInterval > 0) || + (mInitialized == CRL_IP_NOT_INITIALIZED) || + mDoLastAutoUpdate || (mEnableCRLUpdates && + ((mEnableDailyUpdates && mDailyUpdates != null && + mTimeListSize > 0) || + (mEnableUpdateFreq && mAutoUpdateInterval > 0) || + mDoManualUpdate)))) { + + synchronized (this) { + long delay = 0; + long delay2 = 0; + boolean doCacheUpdate = false; + boolean scheduledUpdates = mEnableCRLUpdates && ((mEnableDailyUpdates && mDailyUpdates != null && - mTimeListSize > 0) || - (mEnableUpdateFreq && mAutoUpdateInterval > 0) || - mDoManualUpdate)))) { - - synchronized (this) { - long delay = 0; - long delay2 = 0; - boolean doCacheUpdate = false; - boolean scheduledUpdates = mEnableCRLUpdates && - ((mEnableDailyUpdates && mDailyUpdates != null && - mTimeListSize > 0) || - (mEnableUpdateFreq && mAutoUpdateInterval > 0)); - try { + mTimeListSize > 0) || + (mEnableUpdateFreq && mAutoUpdateInterval > 0)); + if (mInitialized == CRL_IP_NOT_INITIALIZED) initCRL(); @@ -1766,11 +1767,12 @@ public class CRLIssuingPoint implements ICRLIssuingPoint, Runnable { mSignatureAlgorithmForManualUpdate = null; } } - } catch (EBaseException e1) { - // TODO Auto-generated catch block - e1.printStackTrace(); + } } + } catch (EBaseException e1) { + // TODO Auto-generated catch block + e1.printStackTrace(); } mUpdateThread = null; } |