diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-06-11 16:21:26 -0400 |
---|---|---|
committer | Endi Sukma Dewata <edewata@redhat.com> | 2012-06-15 17:12:15 -0500 |
commit | 10326ad4fe1b3db620f43feb3f47c4fd008f3f33 (patch) | |
tree | 4d4a0f719bbbea6d6db53ef3fab5f3717411cfb9 /base/ca/src/com/netscape/ca/CMSCRLExtensions.java | |
parent | c53ca291e21761f1de5417ef596afba395a7f5d1 (diff) | |
download | pki-10326ad4fe1b3db620f43feb3f47c4fd008f3f33.tar.gz pki-10326ad4fe1b3db620f43feb3f47c4fd008f3f33.tar.xz pki-10326ad4fe1b3db620f43feb3f47c4fd008f3f33.zip |
Fixes for Coverity issues of type Stringbuffer, NO_EQUALS_METHOD , REVERSE_INULL,Wrong_Map_Iterators
Diffstat (limited to 'base/ca/src/com/netscape/ca/CMSCRLExtensions.java')
-rw-r--r-- | base/ca/src/com/netscape/ca/CMSCRLExtensions.java | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/base/ca/src/com/netscape/ca/CMSCRLExtensions.java b/base/ca/src/com/netscape/ca/CMSCRLExtensions.java index 507faa8e8..11f810af2 100644 --- a/base/ca/src/com/netscape/ca/CMSCRLExtensions.java +++ b/base/ca/src/com/netscape/ca/CMSCRLExtensions.java @@ -21,6 +21,7 @@ import java.io.IOException; import java.security.cert.CertificateException; import java.util.Enumeration; import java.util.Hashtable; +import java.util.Map; import java.util.StringTokenizer; import java.util.Vector; @@ -581,8 +582,9 @@ public class CMSCRLExtensions implements ICMSCRLExtensions { ip = ca.getCRLIssuingPoint(ipId); } - for (String name : nvp.keySet()) { - String value = nvp.get(name); + for (Map.Entry<String,String> entry : nvp.entrySet()) { + String name = entry.getKey(); + String value = entry.getValue(); if (name.equals(PROP_ENABLE)) { if (!(value.equals(Constants.TRUE) || value.equals(Constants.FALSE))) { @@ -618,8 +620,10 @@ public class CMSCRLExtensions implements ICMSCRLExtensions { boolean crlCACertsOnly = false; boolean issuingDistPointExtEnabled = false; - - CMSCRLExtensions cmsCRLExtensions = (CMSCRLExtensions) ip.getCRLExtensions(); + CMSCRLExtensions cmsCRLExtensions = null; + if (ip != null) { + cmsCRLExtensions = (CMSCRLExtensions) ip.getCRLExtensions(); + } if (cmsCRLExtensions != null) { issuingDistPointExtEnabled = cmsCRLExtensions.isCRLExtensionEnabled(IssuingDistributionPointExtension.NAME); |